LG-4792: Revise email languages layout to avoid text wrapping #5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
approved these changes
Feb 3, 2022
**Why**: As a user, I want all information to be displayed in a clear visual hierarchy without visual design issues, so that I am not distracted while I am signing in or verifying my identity.
aduth
force-pushed
the
aduth-lg-4792-sign-up-email
branch
from
7967ec1 to
504b9f3
Compare
anniehirshman-gsa
approved these changes
Feb 3, 2022
aduth
commented
Feb 4, 2022
| <% end %> | ||
| </ul> | ||
| </div> | ||
| <div class="grid-col-4 tablet:grid-col-6"></div> |
There was a problem hiding this comment.
For posterity: The reason to do it this way where the content column is assigned grid-col-fill and this column is given an explicit width is due to how the USWDS grid will assign flex-grow: 0; flex-shrink: 1 when using explicit widths. This allows the empty column to shrink and allows the grid-col-fill to occupy its space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: As a user, I want all information to be displayed in a clear visual hierarchy without visual design issues, so that I am not distracted while I am signing in or verifying my identity.