-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-4795: Change font to Public Sans #5900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼
40dbe46
to
7fc758f
Compare
This was referenced Feb 11, 2022
3ac0165
to
b09c835
Compare
**Why**: Avoid excess wrapping, match Figma designs
* Match font size between password strength meter label and strength https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.ij7e80fv4x9p * Fix line-height to match body content for heading override classes https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.cjccn2jqw5or * Improve account history text wrapping https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.s69rw07kvjb8 * Inherit h3 styles for Troubleshooting Options heading https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.ar9ig16cx9yv * Reduce padding on IAL2 verify accordion content https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.97mep966gkz4 * Add grid gap for IAL2 verify details https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.1s7zqgip92ek * Fix footer wrap at small viewports https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.ae3a6eue3vf2 * Fix account mobile header wrapping https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.s0lnbwisvwow * Fix email wrapping on account page * Wrap phone number default on mobile https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.st157qhckyoi * Move IAL2 sign-in PII accordion content up https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.yariyhzc6hsn * Fix typo on MFA select screen https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.jj68sbwse7pe * Collapse excess whitespace on webauthn setup https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.hgc1uwxpfono * Adjust vertical spacing for reauthn password https://docs.google.com/document/d/1H2sGTfajE_vFywuS-dErrveE3HYeraOpKqBZoU7zW40/edit#bookmark=id.mveu2u207pjz * Replace b with span.text-bold See: #5937 (comment) * Update specs * Fix positioning of success icon in review accordion * Increase margin above IAL2 review password field * Move IAL2 sign-in description outside footer
2c797ea
to
c3cd821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: As a user, I want to see a consistent font and brand across all login.gov sites, including the IdP, so that I can trust that this website is legitimate.