Lg 3876 remove basscss modules #5944
Conversation
| </table> | ||
| <div class="grid-row"> | ||
| <% [ @codes.first(@codes.length / 2), @codes.last(@codes.length / 2)].each do |section| %> | ||
| <div class="grid-col-6"> |
There was a problem hiding this comment.
How does this look on mobile? Should it be collapsing to single column?
| <div class="grid-col-6"> | |
| <div class="grid-col-12 tablet:grid-col-6"> |
There was a problem hiding this comment.
I coded it to match what we currently have on prod, which is 2 column on mobile
:
There was a problem hiding this comment.
I see. Fair enough. Might be something to look at separately, since it gets kinda tight at small phone sizes like iPhone SE. FYSA @anniehirshman-gsa
There was a problem hiding this comment.
Thanks! I agree that this gets too tight and could be hard to read at small phone sizes. I'm comfortable going to one column (maybe with closing up the spacing between codes a bit) on mobile if that works for y'all? I can ticket it separately if that's out of scope for this - lmk what you prefer
There was a problem hiding this comment.
Per our discussion with @anniehirshman-gsa and Yemesi we decided to make this change in this pull request and update the ticket.
changelog: Improvements, Layout, Remove basscss modules
…ity-idp into lg-3876-remove-basscss-modules
This pull request removes the following bassscss modules:
'basscss-sass/base-reset';
'basscss-sass/base-forms';
'basscss-sass/base-tables';
'basscss-sass/base-typography';
A temp css file called _design-system-waiting-room.scss has been temporary created to support the css styles till we convert to USWDS styles.