Update verify hard fail screens #1640
Conversation
nickbristow
requested review from
el-mapache
and removed request for
el-mapache
|
|
nickbristow
force-pushed
the
updated-identity-verify-hard-fail
branch
5 times, most recently
from
2a80678 to
bb35d39
Compare
**Why**: After a user fails to verify based on supplied info the user is redirected to help pages if logging in directly on the app. If coming from an SP, they are instructed to visit the SP for more help.
nickbristow
force-pushed
the
updated-identity-verify-hard-fail
branch
from
bb35d39 to
4543302
Compare
nickbristow
changed the title
| .mt2.p3.col-12.center.border-box.border.border-teal.rounded-xl | ||
| p.mb3.fs-20p = t('idv.messages.hardfail4_html', sp: decorated_session.sp_name) | ||
| = link_to t('idv.buttons.continue_plain'), | ||
| decorated_session.sp_return_url, |
There was a problem hiding this comment.
I'm not 100% convinced this is the right URL
- for SAML, this URL will be the "The URL of the SP which login.gov provides to users when they wish to go directly to the SP site or cancel out of authentication."
- for OIDC this will be the decline/cancel URL which will probably show an error
I believe our goal is to have SP register a new URL specifically as a help page, so we'll need to add a new migration, update fields in the dashboard, etc etc
I am OK with us merging this as-is but it's wrong and we'll need to plan to fix it in the short-term
There was a problem hiding this comment.
@nickbristow let's talk about how to fix this when you get back
There was a problem hiding this comment.
@zachmargolis you are correct, we don't have the SP's registering a help url atm, I think thats planned.
| hr.mt2 | ||
| .mt2 | ||
| | < | ||
| = link_to ' Return to your login.gov profile', profile_path |
There was a problem hiding this comment.
This needs to be i18n'd
There was a problem hiding this comment.
Also we avoid hardcoding login.gov because we use APP_NAME
zachmargolis
force-pushed
the
updated-identity-verify-hard-fail
branch
from
ed0833e to
e7f9f60
Compare
**Why**: So we can translate the app
Why:
After a user fails to verify based on supplied info
the user is redirected to help pages if logging in
directly on the app. If coming from an SP, they
are instructed to visit the SP for more help.