Deploy RC 430 to Prod #11494
Merged
Deploy RC 430 to Prod #11494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changelog: Upcoming Features, socure, implement handle_connection_error for socure requests * added method definition to lower levels and adding spec tests * Fixing test * Making document_request handle_connection_error return a hash and updating service and controller rspec tests * raising Not implemented at base level * Resoliving PR comment on socure 401 response * fixing test * Updating test and functionality to handle nil responses and nil response bodies * simplifying logic * Fixing nil issue * Updating tests and logic for 401 and 400 responses * Removing & from json parse * Updating to coding standard and defining handle_invalid_response at the top request level * removing uneeded expects from tests, will be replaced with redirect once try again functionality is implemented * updating to use .test in fake socure testing links * Updating fake_socure_endpoint links * Adding safe check for response body * Changing docv_result_request handle_connection_error to return a doc auth response, and changing/updating tests
* Threat metrix initial page * threat metrix helper * changelog: Upcoming Features, Account creation, Threat metrix addiition * fix up threatmetrix naming * fix true * fix up rubocop * add override for csp for threat metrix * fix linting * update to move threatmetrix to idv * add new line * fix indentationg * make threat metrix profiling into a separate partial * fix styling indentation * Threat metrix helper adjustment * add regtistrations threat metrix spec * fix ssn controller and spec * threatmetrix api * update to use locals * return empty hash * update proofer * add device profiling work * Move device profiling over * changelog: Upcoming Features, Authentication Threat Metrix, API creation * add spec for threat_metrix helper * refactor to just parametize proofer * fix rubocop issues * fix initial rspec * add spec for verification request for authentication * remove threat metrix call in completions controller * remove registration emails ref to tmx in completions page * fix threatmetrix step helper spec * update analytics event * change to proofing applicant * fix analytics event lint * update application yml file * remove current sp * use job to query threatmetrix * update add mfa * add mfa spec to make sure job is properly called * fix tests around addmfa call * put back error response * remove unneded comments * update completions with empty space * remove device profiling result * leverage same verification request * take into account gsub * update verificationr spec * fix rspe * address comment, feature flag toggle, and application.yml * update identity config * make sure spec is when enabled * rubocop * move yml comment, fix spacing and clean up specs
* Try consolidating analytics stubbing logic * Limit user assertion to only if passed * Add support for analytics stubbing of feature specs * Fix duplicate logging for successful email confirmation changelog: Internal, Analytics, Fix duplicate logging for successful email confirmation * Remove assumptions of logging from passwords controller * Log email confirmation validation results for failure
* changelog: Upcoming Features, Email Sharing, Update email sharing content to be clearer to users * changelog: User-Facing Improvements, Connected Accounts, Select Email page content change * normalize yaml * fix feature specs * change to ensure sp renders properly * fix rubocop error
…behavior (#11467) * Extract shared email confirmation behavior as needed changelog: Internal, Performance, Extract shared email confirmation behavior as needed * Restore valid token processing Probably redundant, but safer to limit impact for initial refactoring
* Add FormResponse#to_hash as alias of #to_h changelog: Internal, Form Validation, Alias FormResponse#to_hash to #to_h * Replace splatted FormResponse#to_h with implicit Search: \*\*(\w*)(result|response).to_h([),]) Replace: **$1$2$3 * Collapse line breaks of splatted FormResponse#to_hash * Revert DDP proofer hashing result
…1469) * LG-14863: Add UI to simulate account creation ThreatMetrix result changelog: Upcoming Features, Fraud Mitigation, Add UI to simulate ThreatMetrix result in authentication * Add feature spec for ThreatMetrix account creation * Reuse existing currentScript destructured reference
s/为了你的安全/出于安全考虑/g per DOS LQA changelog: Bug Fixes, Translations, Updates Simplified Chinese strings
… resubmission with TMX enabled for Account creation (#11471) * changelog: Bug Fixes, Threatmetrix Account creation, Fixes issue with resubmission with TMX enabled for Account creation * add rspec for tmx profiling * fix sign up spec, and remove unneeded html rendering
changelog: User-Facing Improvements, Translations, Fix errant piv/cac capitalization
changelog: User-Facing Improvements, In-person proofing, Fix barcode page due date format for spanish, french, and chinese translations; Improve spanish translation for information alert. This commit updates the time.formats.event_date for Spanish, French, and Chinese, so more than just EIPP/ID-IPP flows are affected by this change. See #11398 for the areas affected.
* started work on ticket, finished standard controller functionality and tests * working on ticket * changelog: Upcoming Features, socure vendor, setting socure capture app url in document sessions table
…n doesn't lead to partner (#11439) * changelog: User-Facing Improvements, Partner account, confirm link leads to partner sign-in * uses form params to pass along request_id * remove stray variable, add test for SendAddEmailConfirmation service * remove un-needed nil, revise spec to include symbol, pass request_id in UserMailerPreview * assume nil in mailer preview add_email, remove store sp metadata from emails controller * iterate on storing sp_session * remove from after_sign_in_for() method * test visits to select email view for multiple emails * revise spec to sync with merge conflict changes * remove unneeded param * reorder call params * recast params as symbols * remove unneeded session setup, pass email as keyword in resend * pass request id in resend * improve spec use of subject
* Fail Rubocop on warn logging changelog: Internal, Automated Testing, Fail static analysis linting when warning messages emitted * Try output parsing for Rubocop namespace warning * Make tmp dir before writing Rubocop results Doesn't exist by default at this point in CI * Reroute stderr to tmp file * Use correct namespace for LineLength cop
* changelog: Upcoming Features, socure, implement handle_connection_error for socure requests * added method definition to lower levels and adding spec tests * Fixing test * Making document_request handle_connection_error return a hash and updating service and controller rspec tests * raising Not implemented at base level * Resoliving PR comment on socure 401 response * fixing test * Updating test and functionality to handle nil responses and nil response bodies * simplifying logic * Fixing nil issue * Updating tests and logic for 401 and 400 responses * Removing & from json parse * Updating to coding standard and defining handle_invalid_response at the top request level * removing uneeded expects from tests, will be replaced with redirect once try again functionality is implemented * updating to use .test in fake socure testing links * Updating fake_socure_endpoint links * Adding safe check for response body * Changing docv_result_request handle_connection_error to return a doc auth response, and changing/updating tests * Fixing tests
changelog: Internal, Performance, Remove unused email styles
* delete one-time tasks that are no longer needed * [skip changelog]
LG-14007: Handle redirect from CaptureApp Upon redirect from the Socure CaptureApp, we load the result stored in the DocumentCaptureSession, and if successful, redirect to the SSN entry step. - switch callback to a GET - extract handle_stored_result to the DocumentCaptureConcern - mv `cancel_establishing_in_person_enrollments` to the concern and call from socure doc cap controller changelog: Upcoming Features, Identity Verification, Handle Socure handoff. --------- Co-authored-by: John Maxwell <[email protected]>
aduth
requested review from
n1zyy,
solipet,
mdiarra3,
eileen-nava,
jmax-gsa,
kevinsmaster5,
shanechesnutt-ft and
AShukla-GSA
mitchellhenke
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features