Add FormResponse#to_hash to support implicit hash conversion #11476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmargolis
approved these changes
Nov 7, 2024
changelog: Internal, Form Validation, Alias FormResponse#to_hash to #to_h
Search: \*\*(\w*)(result|response).to_h([),]) Replace: **$1$2$3
aduth
force-pushed
the
aduth-form-response-to-hash
branch
from
f7187a4 to
1516638
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Adds
FormResponse#to_hashas an alias ofFormResponse#to_hto support implicit hash conversion.Before:
After:
Existing instances updated with find and replace pattern:
\*\*(\w*)(result|response).to_h([),])**$1$2$3Related Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1730987694583649
Related information about implicit and explicit type conversions in Ruby: https://zverok.space/blog/2016-01-18-implicit-vs-expicit.html
📜 Testing Plan
Verify build passes.