Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused email styles #11484

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Remove unused email styles #11484

merged 1 commit into from
Nov 8, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Nov 8, 2024

🛠 Summary of changes

Removes a handful of styles from the email mailer stylesheet which are currently unused.

📜 Testing Plan

Verify no regressions in mailer templates visual appearance.

http://localhost:3000/rails/mailers/

changelog: Internal, Performance, Remove unused email styles
Copy link
Member

@n1zyy n1zyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at email previews and found that everything is still rendered as expected. Thanks for streamlining things!

Comment on lines -28 to -31
.mr-tiny {
margin-right: 4px;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell, Mr. Tiny. :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫗

@aduth aduth merged commit 031daaf into main Nov 8, 2024
2 checks passed
@aduth aduth deleted the aduth-unused-email-styles branch November 8, 2024 19:40
@aduth aduth mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants