Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

glossary component changes #53

Open
wants to merge 92 commits into
base: master
Choose a base branch
from

Conversation

cschwinderg
Copy link

This pull request fixes a few things that our team ran into while using this component.

  • Added a function for collapsing all terms.
    • Issue:
      • Before: If you expanded some terms, closed the glossary component and then reopened the glossary all of those terms would still be expanded.
      • After: Whenever the user closes and reopens the glossary, all the terms will be collapsed. Similarly, if the user clicks a different term only the selected term will be expanded.
  • Made the searches and term clicks case insensitive. Previously terms had to be all lower case.
    • Issue:
      • Before: The data-term value would only work if it was all lower case, which meant the term the user clicked on would always show up in the search box all lower case.
      • After: The data-term value is case insensitive, allowing the text in the search box to match the casing of the term being clicked.
  • Prevent focus on search box when clicking on a term.
    • Issue: On mobile devices, clicking a term would open the keyboard which would take up most of the screen. This was happening because focus was being assigned to the search box.
  • Prevent focus on the glossary button when the user clicks somewhere outside of the glossary component.
    • Issue: Whenever the user clicked outside of the glossary, focus was given to the glossary toggle button. This focus change would cause the screen to jump to the glossary toggle button, instead of just closing the glossary.

cschwinderg and others added 30 commits October 8, 2019 15:01
… button instead of whatever the user clicked on. Also fixed a bug where clicking outside of the glossary wasn't working.
…e-focussing-on-toggle-button

Bugfix/prevent close focussing on toggle button
…-opens-keyboard

Removed focus on search box when clicking on a term.
…cordions-on-close

Enhance/collapse accordions on close
…llapse-accordions-on-close

Revert "Enhance/collapse accordions on close"
…karound an error relating to not finding the content.
…cordions-on-close

Enhance/collapse accordions on close
@rocheller123
Copy link

@cschwinderg This looks like an old issue and has conflicts. Please review.

@JJediny JJediny requested a review from a team September 10, 2021 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants