Bugfix/old ios safari bugs #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scrollTo is not supported
cschwinderg
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://app.breeze.pm/projects/100762/cards/3442549
Main changes:
To support older browsers and devices (like iPads)
touchstartwhich is fired on touch events on older iPads.element.scrollTo()is not supported in older browsers I've switched to a more widely supported function that does the same thing.element.style =toelement.style.csstext =because in older versions of iOS Safari thestyleattribute is readonly.Steps to test:
In the HMW client folder's package.json, change this line:
"glossary-panel": "github:Eastern-Research-Group/glossary"to
"glossary-panel": "github:Eastern-Research-Group/glossary#bugfix/old-ios-safari-bugs"Run
npm installin the client folder.Run the app locally. Verify the glossary works as it should.
To test on an older iPad, I used the Browserstack to test my localhost:3000 on Browserstack's iPad Mini 4 - iOS 9.3
Verify that touch events correctly open and close the glossary popup.