Bugfix/safari 9 issues #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cschwinderg if you're short on time we can merge this and test it on Brad's iPad because that's the real test. |
cschwinderg
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://app.breeze.pm/projects/100762/cards/3442549 (this ticket is related to recent ticket comments)
Main changes:
Safari 9 and below treats
element.styleas a read-only attribute. Changed all usage ofelement.styletoelement.style.cssTextto get around this issueSteps to test:
In the HMW client folder's package.json, change this line:
"glossary-panel": "github:Eastern-Research-Group/glossary"to
"glossary-panel": "github:Eastern-Research-Group/glossary#bugfix/safari-9-issues"Run
npm installin the client folder.Run the app locally. Verify the glossary works as it should.
To test on an older iPad, I used the Browserstack to test my localhost:3000 on Browserstack's iPad Mini 4 - iOS 9.3
Verify that touch events correctly open and close the glossary popup.
Search a location on the Community tab.
Click a glossary term and verify that the Glossary panel opens and displays the term you clicked.
Note: Arcgis 4.x does not appear to be supported in older browsers like Safari 9 so the map won't show on this emulator, more info in the Breeze ticket above.