Merge pull request #145 from zzzz465/fix/default-version

fix: default typeInfo not extracted
zzzz465 · Oct 12, 2022 · ab29d56 · ab29d56
2 parents 2067694 + fd741cc
commit ab29d56
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/vsc-extension/src/resources/cachedTypeInfoProvider.ts b/vsc-extension/src/resources/cachedTypeInfoProvider.ts
@@ -37,7 +37,8 @@ export class CachedTypeInfoProvider implements Provider {
     transports: [log],
   })
 
-  private static readonly extractorVersion = new semver.SemVer('0.7.0')
+  // TODO: move this line to extractor.
+  private static readonly extractorVersion = new semver.SemVer('0.8.0')
 
   get dllCacheDirectory(): string {
     return path.join(this.pathStore.cacheDirectory, 'dlls')

diff --git a/vsc-extension/src/resources/typeInfoProvider.ts b/vsc-extension/src/resources/typeInfoProvider.ts
@@ -98,6 +98,10 @@ export class TypeInfoProvider implements Provider {
 
   async checkCoreDLLVersion(DLLPath: string, version: semver.SemVer): Promise<boolean> {
     this.log.debug('checking Core DLL version...')
+    if (version.compare(TypeInfoProvider.defaultVersion) === 0) {
+      this.log.debug('version is default. skipping check.')
+      return true
+    }
 
     const fileVersionOrErr = await this.getCoreDLLVersion(DLLPath)
     if (fileVersionOrErr instanceof Error) {