Modular error printing #50
Conversation
| fputs("Unexpected character:\n", stream); | ||
| BarToken_print(compiler->bar, stream); | ||
|
|
||
| if(fprintf(stream, "\n%*s^", (int) (compiler->position - 1), " ") < 0) { |
There was a problem hiding this comment.
We're likely gonna use the exact same trick inside the token module; might be worth extracting the string formatting into a helper method.
Update NoteCompiler to make use of error strings
Update Interpreter to use error strings
| char* bar; | ||
| NoteCompilerState state; | ||
| size_t bar_length; | ||
| char* filename; |
There was a problem hiding this comment.
If we pass the filename in the constructor here, we should probably do that for all the other modules as well.
(Maybe not for the interpreter, if the idea is to be able to potentially load modules from different files?)
Also need to think about scope. (Caller needs to guarantee the string stays around for as long as the compiler/lexer whatever is used. This is fine, but should really be documented.)
There was a problem hiding this comment.
(Thinking more about this, we might want to store the (pointer-to) filename in the tokens instead. There's little sense in having the line information in one place, and the file name in another.)
Closes #38