Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting #38

Open
zzril opened this issue Oct 11, 2024 · 1 comment · May be fixed by #45 or #50
Open

Better error reporting #38

zzril opened this issue Oct 11, 2024 · 1 comment · May be fixed by #45 or #50
Assignees

Comments

@zzril
Copy link
Owner

zzril commented Oct 11, 2024

Error messages are pretty generic atm. Especially the (quite common) case where the notes' lengths in a bar don't sum up to 1 currently leads to a cryptic "Internal interpreter error".

Improve these error messages and point the user to what exactly was wrong.

Note: In order to determine if the (cumulative) length of the notes in a bar is correct, we depend on the floating-point arithmetic to be exact for powers of 2. We should verify that is indeed correct on all destination platforms, and otherwise implement a fallback solution (e.g. a tolerance window of a couple of samples to still accept a bar).
Keep in mind that the notes' lengths will get more complicated once #36 is implemented.

@zzril
Copy link
Owner Author

zzril commented Oct 15, 2024

Part of this is currently addressed in #42 . More specifically, error return codes are introduced in that PR to describe what exactly the problem was.
However, actually printing out sensible error messages based on the returned error codes is not implemented in that PR.

@zzril zzril self-assigned this Oct 15, 2024
@zzril zzril linked a pull request Oct 15, 2024 that will close this issue
@zzril zzril linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant