pull from origin #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement max message size rather then cap with fixed number of transactions Adding transactions to the RLP until the message size exceeds the limit and then send that. * fix final variables * Update AbstractRLPOutput.java add javadoc * pr discussion put this factory method on LimitedTransactionsMessages rather than TransactionsMessage since it returns a LimitedTransactionsMessages. * SpotlessApply * fix PR discussion - simplify design - remove useless code * Update LimitedTransactionsMessages.java * fix PR discussion - simplify logic - add tests * Update AbstractRLPOutput.java * Update ethereum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/messages/LimitedTransactionsMessages.java Co-Authored-By: abdelhamidbakhta <[email protected]> * Update Transaction.java * fix PR discussion * fix PR discussion - add tests * Update BlockDataGenerator.java * Update LimitedTransactionsMessagesTest.java fix PR unit test * Update LimitedTransactionsMessagesTest.java * Update LimitedTransactionsMessagesTest.java Use LinkedHashSet to preserve order. * Update LimitedTransactionsMessagesTest.java * follow up PR
Default values are currently unchanged but increasing both these values to 4 appears to improve sync performance for both ropsten and Mainnet fast syncs.
Moves init code into a separate builder instead of a static init method, with common code in an abstract base class and subclasses of the builder for each of the consensus variants.
Use class field rather than creating new instance for each call.
DebugTraceBlockByNumber now requires hex numbers as input instead of decimal and supports shortcuts like 'latest' consistent with other methods like EthGetBlockByNumber.
…le (#1328) * [PAN-1878] Provide error message when invalid key specified in key file - display explicit message when invalid key file is specified * Update KeyPairUtilTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)