This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Use header validation mode for ommers #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ched and detached rules since they won't be validated ahead of time.
mbaxter
approved these changes
Apr 23, 2019
| @@ -224,6 +224,17 @@ private boolean isOmmerValid( | |||
| return false; | |||
| } | |||
|
|
|||
| if (ommerValidationMode != HeaderValidationMode.LIGHT | |||
| && ommerValidationMode != HeaderValidationMode.LIGHT_SKIP_DETACHED | |||
| && ommerValidationMode != HeaderValidationMode.LIGHT_DETACHED_ONLY) { | |||
There was a problem hiding this comment.
Could this be clarified with something like: !HeaderValidationMode.isLight(ommerValidationMode) ?
…ation into HeaderValidationMode to make things more readable.
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
During a fast sync, we should only fully validate a random sampling of ommer headers and otherwise skip the proof of work validity and ancestry checks which are expensive.
Profiling shows the PoW checks in particular were causing the majority of CPU usage during a fast sync for an ethash chain.