bugfix: Update stream-setting checkboxes from subscription events. #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: M
|
I'm wary from the description that a polling approach is the way to go with this, but rather that we do something like register a callback when opening the popup, which is triggered on events. That could be the starting point for a shift in how we glue parts of the application together, including loosening the coupling between the model and UI. |
zee-bit
force-pushed
the
bugfix-checkbox-update-from-events
branch
from
dec5b36 to
4fc75a7
Compare
|
I have changed my approach from polling to callback-based. This works well as a v1, but I need some feedback on improvement so that I can generalize this for other UI elements that depend on events for updation.
|
This commit adds a function in StreamInfoView that runs asynchronously at regular interval checking and updating the checkboxes. The function is not yet executed from the StreamInfo view, because it doesnt yet have the logic to stop the asynch function.
This commit adds two new functions in model.py: - register_callback(): That registers callbacks for UI elements and stores them in model.callbacks data-structure. - process_callback(): That processes the corresponding callback that are already registered after getting triggered from events. These combined allow us to dynamically update the checkboxes in stream_info popup after receiving events. Fixes zulip#747.
zee-bit
force-pushed
the
bugfix-checkbox-update-from-events
branch
from
4fc75a7 to
b2defda
Compare
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this pull request
Jul 5, 2021
This commit adds a new checkbox 'Visual desktop notification' in the Stream settings section inside StreamInfoView. It uses model's visual_notified_streams to get the initial state of the checkbox and henceforth events to sync the "desktop notifications" data between ZT <-> server. The checkboxes are not updated dynamically after events but the underlying data structure gets updated, hence re-opening the StreamInfo view will display the correct state. We have a WIP PR zulip#981 that deals with updating these checkboxes dynamically while the popup is still open. Tests amended. Fixes zulip#887.
zee-bit
added a commit
to zee-bit/zulip-terminal
that referenced
this pull request
Jul 10, 2021
This commit adds a new checkbox 'Visual desktop notification' in the Stream settings section inside StreamInfoView. It uses model's visual_notified_streams to get the initial state of the checkbox and henceforth events to sync the "desktop notifications" data between ZT <-> server. The checkboxes are not updated dynamically after events but the underlying data structure gets updated, hence re-opening the StreamInfo view will display the correct state. We have a WIP PR zulip#981 that deals with updating these checkboxes dynamically while the popup is still open. Tests amended. Fixes zulip#887.
zee-bit
changed the title
neiljp
pushed a commit
to neiljp/zulip-terminal
that referenced
this pull request
Jul 13, 2021
This commit adds a new checkbox 'Visual desktop notification' in the Stream settings section inside StreamInfoView. It uses model's visual_notified_streams to get the initial state of the checkbox and henceforth events to sync the "desktop notifications" data between ZT <-> server. The checkboxes are not updated dynamically after events but the underlying data structure gets updated, hence re-opening the StreamInfo view will display the correct state. We have a WIP PR zulip#981 that deals with updating these checkboxes dynamically while the popup is still open. Tests amended. Fixes zulip#887.
neiljp
pushed a commit
to neiljp/zulip-terminal
that referenced
this pull request
Jul 13, 2021
This commit adds a new checkbox 'Visual desktop notification' in the Stream settings section inside StreamInfoView. It uses model's visual_notified_streams to get the initial state of the checkbox and henceforth events to sync the "desktop notifications" data between ZT <-> server. The checkboxes are not updated dynamically after events but the underlying data structure gets updated, hence re-opening the StreamInfo view will display the correct state. We have a WIP PR zulip#981 that deals with updating these checkboxes dynamically while the popup is still open. Tests amended. Fixes zulip#887.
neiljp
pushed a commit
to zee-bit/zulip-terminal
that referenced
this pull request
Jul 13, 2021
This commit adds a new checkbox 'Visual desktop notification' in the Stream settings section inside StreamInfoView. It uses model's visual_notified_streams to get the initial state of the checkbox and henceforth events to sync the "desktop notifications" data between ZT <-> server. The checkboxes are not updated dynamically after events but the underlying data structure gets updated, hence re-opening the StreamInfo view will display the correct state. We have a WIP PR zulip#981 that deals with updating these checkboxes dynamically while the popup is still open. Tests amended. Fixes zulip#887.
neiljp
pushed a commit
that referenced
this pull request
Jul 13, 2021
This commit adds a new checkbox 'Visual desktop notification' in the Stream settings section inside StreamInfoView. It uses model's visual_notified_streams to get the initial state of the checkbox and henceforth events to sync the "desktop notifications" data between ZT <-> server. The checkboxes are not updated dynamically after events but the underlying data structure gets updated, hence re-opening the StreamInfo view will display the correct state. We have a WIP PR #981 that deals with updating these checkboxes dynamically while the popup is still open. Tests amended. Fixes #887.
|
Heads up @zee-bit, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
neiljp
added
area: event handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the mismatch between stream settings if the
StreamInfopopup is opened in ZT and subscription events are received from the server. The current approach registers a callback when theStreamInfoViewis opened and looks forsubscriptionevents to trigger the callback, which in turn updates the checkbox UI.Fixes #747.