Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notification checkboxes in Stream Info view. #887

Open
1 of 4 tasks
zee-bit opened this issue Jan 23, 2021 · 4 comments · Fixed by #900
Open
1 of 4 tasks

Add notification checkboxes in Stream Info view. #887

zee-bit opened this issue Jan 23, 2021 · 4 comments · Fixed by #900
Labels
area: event handling How events from the server are responded to area: notifications area: popup: stream

Comments

@zee-bit
Copy link
Member

zee-bit commented Jan 23, 2021 •
edited by neiljp
Loading

This issue extends PR #880 and should work towards improving the Stream Info view in ZT. Currently, there are just two checkboxes in StreamInfoView(mute_stream & pin_to_top). These are fine but we want to add more checkboxes related to Stream notifications. We could potentially add:

  • Audible desktop notification
  • Email notification
  • Visual desktop notification, and
  • Mobile notification

The logic could be borrowed from zulip/zulip or those other checkboxes already present in ZT. Zulip's API documentation should prove helpful in tackling this issue.

@neiljp I have opened this issue(to keep track of the tasks that needs to be done, and) as a continuation of the work I already did in #880

NOTE These require underlying fetching handling updates of the settings, in addition to the UI, ie. we expect to synchronize these with the server (though we might have our settings in future) -- neiljp
@zee-bit
Copy link
Member Author

zee-bit commented Jan 23, 2021

@zulipbot claim

@zee-bit zee-bit mentioned this issue Jan 24, 2021
Merged
6 tasks
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 30, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
de24457 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses the subscription
field of initial_data's response, and events to sync its settings with
that of the server.

Tests amended.
Partially Fixes zulip#887.
@zee-bit zee-bit mentioned this issue Jan 30, 2021
Merged
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jan 31, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
3691fc4 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses the subscription
field of initial_data's response to set the initial state of the checkbox,
and henceforth events to sync its settings between client <-> server. The
notify_user code has been updated to interact properly with the checkbox
settings.

Tests amended.
Partially Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Feb 1, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
12d2537 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses the subscription
field of initial_data's response to set the initial state of the checkbox,
and henceforth events to sync its settings between client <-> server. The
notify_user code has been updated to interact properly with the checkbox
settings.

Tests amended.
Partially Fixes zulip#887.
@zulipbot
Copy link
Member

Hello @zee-bit, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Feb 21, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
0934814 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses the subscription
field of initial_data's response to set the initial state of the checkbox,
and henceforth events to sync its settings between client <-> server. The
notify_user code has been updated to interact properly with the checkbox
settings.

Tests amended.
Partially Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Feb 22, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
c0d22b6 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses the subscription
field of initial_data's response to set the initial state of the checkbox,
and henceforth events to sync its settings between client <-> server. The
notify_user code has been updated to interact properly with the checkbox
settings.

Tests amended.
Partially Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 12, 2021
@zee-bit
model: Support subscription events for desktop_notifications.
7fd362b 
This commit is the first part of adding full support for desktop
notifications. This commit handles the event part of the objective,
the UI(i.e. desktop notification checkbox) will be added in the next
commit. Corresponding tests for model functions have also been added.

Tests amended.
Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 12, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
68c3cdf 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses subscription
from initial_data to set the initial state of the checkbox, and
henceforth events to sync its settings between client <-> server.
The notify_user code has been updated to interact properly with the
checkbox settings and according to the points mentioned in issue zulip#666.

Tests amended.
Partially Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 15, 2021
@zee-bit
model: Support subscription events for desktop_notifications.
4fb5b75 
This commit is the first part of adding full support for desktop
notifications. This commit handles the event part of the objective,
the UI(i.e. desktop notification checkbox) will be added in the next
commit. Corresponding tests for model functions have also been added.

Tests amended.
Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 15, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
c3c6206 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses subscription
from initial_data to set the initial state of the checkbox, and
henceforth events to sync its settings between client <-> server.
The notify_user code has been updated to interact properly with the
checkbox settings and according to the points mentioned in issue zulip#666.

Tests amended.
Partially Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 26, 2021
@zee-bit
model: Support subscription events for desktop_notifications.
a3825cf 
This commit is the first part of adding full support for desktop
notifications. This commit handles events related to subscription's
desktop_notifications field.
The UI(i.e. desktop notification checkbox) will be added in the next
commit. Corresponding tests for model functions have also been added.

Tests amended.
Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Mar 26, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
58d970e 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses subscription
from initial_data to set the initial state of the checkbox, and
henceforth events to sync its settings between ZT <-> server.

The condition for notify_user() has also been refined to interact
properly with the checkbox settings and according to the points
mentioned in issue zulip#666.

Tests amended.
Partially Fixes zulip#887.
@zee-bit zee-bit mentioned this issue Mar 29, 2021
Open
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 5, 2021
@zee-bit
model: Support subscription events for desktop_notifications.
086d9f9 
This commit is the first part of adding full support for desktop
notifications. This commit handles events related to subscription's
desktop_notifications field.
The UI(i.e. desktop notification checkbox) will be added in the next
commit. Corresponding tests for model functions have also been added.

Tests amended.
Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jun 5, 2021
@zee-bit
model/views: Add Visual desktop notification checkbox in Stream Info.
460281c 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses subscription
from initial_data to set the initial state of the checkbox, and
henceforth events to sync its settings between ZT <-> server.

The condition for notify_user() has also been refined to interact
properly with the checkbox settings and according to the points
mentioned in issue zulip#666.

Tests amended.
Partially Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 5, 2021
@zee-bit
views: Add "Visual desktop notification" checkbox in Stream Info.
e23e4bf 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses model's
visual_notified_streams to get the initial state of the checkbox and
henceforth events to sync the "desktop notifications" data between
ZT <-> server.

The checkboxes are not updated dynamically after events but the
underlying data structure gets updated, hence re-opening the StreamInfo
view will display the correct state. We have a WIP PR zulip#981 that deals
with updating these checkboxes dynamically while the popup is still open.

Tests amended.

Fixes zulip#887.
zee-bit added a commit to zee-bit/zulip-terminal that referenced this issue Jul 10, 2021
@zee-bit
views: Add "Visual desktop notification" checkbox in Stream Info.
3f302de 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses model's
visual_notified_streams to get the initial state of the checkbox and
henceforth events to sync the "desktop notifications" data between
ZT <-> server.

The checkboxes are not updated dynamically after events but the
underlying data structure gets updated, hence re-opening the StreamInfo
view will display the correct state. We have a WIP PR zulip#981 that deals
with updating these checkboxes dynamically while the popup is still open.

Tests amended.

Fixes zulip#887.
neiljp pushed a commit to neiljp/zulip-terminal that referenced this issue Jul 13, 2021
@zee-bit @neiljp
views: Add "Visual desktop notification" checkbox in Stream Info.
3bf9edf 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses model's
visual_notified_streams to get the initial state of the checkbox and
henceforth events to sync the "desktop notifications" data between
ZT <-> server.

The checkboxes are not updated dynamically after events but the
underlying data structure gets updated, hence re-opening the StreamInfo
view will display the correct state. We have a WIP PR zulip#981 that deals
with updating these checkboxes dynamically while the popup is still open.

Tests amended.

Fixes zulip#887.
neiljp pushed a commit to neiljp/zulip-terminal that referenced this issue Jul 13, 2021
@zee-bit @neiljp
views: Add "Visual desktop notification" checkbox in Stream Info.
3bb34b0 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses model's
visual_notified_streams to get the initial state of the checkbox and
henceforth events to sync the "desktop notifications" data between
ZT <-> server.

The checkboxes are not updated dynamically after events but the
underlying data structure gets updated, hence re-opening the StreamInfo
view will display the correct state. We have a WIP PR zulip#981 that deals
with updating these checkboxes dynamically while the popup is still open.

Tests amended.

Fixes zulip#887.
neiljp pushed a commit to zee-bit/zulip-terminal that referenced this issue Jul 13, 2021
@zee-bit @neiljp
views: Add "Visual desktop notification" checkbox in Stream Info.
28bafd6 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses model's
visual_notified_streams to get the initial state of the checkbox and
henceforth events to sync the "desktop notifications" data between
ZT <-> server.

The checkboxes are not updated dynamically after events but the
underlying data structure gets updated, hence re-opening the StreamInfo
view will display the correct state. We have a WIP PR zulip#981 that deals
with updating these checkboxes dynamically while the popup is still open.

Tests amended.

Fixes zulip#887.
neiljp pushed a commit that referenced this issue Jul 13, 2021
@zee-bit @neiljp
views: Add "Visual desktop notification" checkbox in Stream Info.
bb56534 
This commit adds a new checkbox 'Visual desktop notification' in the
Stream settings section inside StreamInfoView. It uses model's
visual_notified_streams to get the initial state of the checkbox and
henceforth events to sync the "desktop notifications" data between
ZT <-> server.

The checkboxes are not updated dynamically after events but the
underlying data structure gets updated, hence re-opening the StreamInfo
view will display the correct state. We have a WIP PR #981 that deals
with updating these checkboxes dynamically while the popup is still open.

Tests amended.

Fixes #887.
@zee-bit
Copy link
Member Author

zee-bit commented Jul 13, 2021

Sorry for the "Fixes" comment on the PR, this isn't completely resolved yet. Re-opening!

@zee-bit zee-bit reopened this Jul 13, 2021
@neiljp neiljp added area: UI General user interface update area: event handling How events from the server are responded to area: notifications labels Mar 22, 2022
@zulipbot
Copy link
Member

Hello @zulip/server-notifications members, this issue was labeled with the "area: notifications" label, so you may want to check it out!

@neiljp neiljp added area: popup: stream and removed area: UI General user interface update labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: event handling How events from the server are responded to area: notifications area: popup: stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

model/views: Add notification checkboxes in Stream Info popup. zee-bit/zulip-terminal
3 participants
@neiljp @zulipbot @zee-bit