-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploaded PDF can't be viewed #3487
Comments
Other related issues:
|
Maybe also this #2115 |
Fixes zulip#3487 Fixes zulip#3303 (but does not implement the exact suggestion) Just as we do with images, check if a link is local and is poining to `/user_uploads/`. If so, adds the `api_key` value to the url to enable opening it in Chrome Custom Tab / Safari View. The file can then be downloaded via the oveflow menu (three-dots) on Android. On iOS, similar actions can be taken via the 'Share' button available at the bottom of the screen.
After some research and experiments, that looks to be the same issue as #3303 The difference is the platforms:
|
Fixes zulip#3487 Fixes zulip#3303 (but does not implement the exact suggestion) Just as we do with images, check if a link is local and is poining to `/user_uploads/`. If so, adds the `api_key` value to the url to enable opening it in Chrome Custom Tab / Safari View. The file can then be downloaded via the oveflow menu (three-dots) on Android. On iOS, similar actions can be taken via the 'Share' button available at the bottom of the screen.
Thanks @borisyankov for the investigation, and the additional link! Based on those findings, I'll close this to consolidate on #3303 -- though as noted there, the set of reports is still a bit confusing and doesn't quite fit any pattern we yet understand. (In particular the original report in #3303 is on Android but describes a login screen.) |
A user reports:
The recipients they've heard from are all on Android; we don't know if the issue is also present on iOS.
Apparently it did work for another recipient, though, also on Android!
So that could be a very interesting clue.
I briefly experimented trying to reproduce it: I uploaded a PDF from the webapp, sent the message, saw it on the mobile app, and tried following the link. For me with v24.0.113 on Android 9 aka P, the issue
When it reproduces, the behavior is:
sagas.pdf
is the filename of the PDF; extra space sic)The difference between servers is presumably because chat.zulip.org hosts uploaded files locally, while zulipchat.com hosts them on S3. In particular on zulipchat.com (and with the S3 backend generally), when the client requests an uploaded file, the server returns a redirect to a URL in S3; we may not be handling the redirect properly.
If so, this may be another symptom of the same underlying issue as the cause of #3124 .
The text was updated successfully, but these errors were encountered: