Update to RGB Matrix LED structure #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
force-pushed
the
per_key_matrix_effects_part_1
branch
from
cfe7b25 to
cd93296
Compare
|
Rebasing reduced thee file size, so Travis CI no longer fails |
|
@fdidron just making sure, you're holding off on this, because of the significant change to the rgb matrix structure, correct? If so, that's fine, and there is qmk#5783 that we may want to wait on, to merge at the same time. It's not an insignificant change, but should further optimize the rgb matrix code. |
|
@drashna exactly, thought I would hold until the rest of the changes are merged. |
Updated effects to test led flags Updated massdrop to use new flags field for led toggle
drashna
force-pushed
the
per_key_matrix_effects_part_1
branch
from
cd93296 to
6364fe4
Compare
… - part 2) (qmk#5783) * Initial conversion of the rgb_led struct * Converting last keyboard & updating effects to take advantage of the new structure * New struct should not be const * Updated docs * Changing define ___ for no led to NO_LED * Missed converting some keymap usages of the old struct layout
* RGB Matrix Typing Heatmap Effect * Fixing file name and effect init
drashna
changed the title
|
There is actually one more PR that I'd like to wait on before this gets merged. qmk#5811 optimizes a number of things here, too. |
drashna
force-pushed
the
per_key_matrix_effects_part_1
branch
2 times, most recently
from
ad7278a to
fa8fe56
Compare
|
This is ready to ship! |
drashna
force-pushed
the
per_key_matrix_effects_part_1
branch
from
83da6e3 to
3880462
Compare
* clean up rgb matrix extern usage Moved rgb matrix boiler plate into macros Rebased onto typing heatmap pr * Fixing the reversed frame buffer access in digital rain * Fixing digital rain & typing heatmap if keyreactive effects are not enabled * Apply suggestions from code review Co-Authored-By: Drashna Jaelre <[email protected]> * Adding parenthesizes to DRIVER_LED_TOTAL where necessary * Updated docs * added notes about parentheses
drashna
force-pushed
the
per_key_matrix_effects_part_1
branch
from
3880462 to
df947e1
Compare
drashna
force-pushed
the
per_key_matrix_effects_part_1
branch
from
df947e1 to
c4f2f95
Compare
derp, forgot to remove the pragma once
* Fixing hsv to rgb where s is 0 and v is < 255 * Update color.c
…mk#5877) * Spirals, Pinwheels, and Documentation....Oh My! * Spiral effect band thickness adjustments * Fixing animation spin directions
fdidron
approved these changes
May 20, 2019
jacostro
added a commit
to jacostro/zsa_qmk
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the rgb LED structure to allow for much more customized effects.
This is not all of it, just the start of the code changes.
It may be best to leave this alone until the rest of the code changes are present.
However, Travis CI fails due to the reactive keymap being too large. (the reactive keymap has all reactive modes enabled, which .... is a LOT)