rgb_led struct conversion (aka: Per led (key) type rgb matrix effects - part 2) #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XScorpion2
changed the title
drashna
requested review from
mechmerlin,
drashna,
ezuk,
algernon,
fredizzimo,
jackhumbert,
noroadsleft,
skullydazed and
yanfali
fauxpark
reviewed
May 4, 2019
yanfali
reviewed
May 4, 2019
drashna
approved these changes
May 5, 2019
drashna
reviewed
May 6, 2019
drashna
reviewed
May 7, 2019
|
Merge conflicts, because my keymap PR got merged. |
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 8, 2019
… - part 2) (qmk#5783) * Initial conversion of the rgb_led struct * Converting last keyboard & updating effects to take advantage of the new structure * New struct should not be const * Updated docs * Changing define ___ for no led to NO_LED * Missed converting some keymap usages of the old struct layout
KauyonKais
pushed a commit
to KauyonKais/qmk_firmware
that referenced
this pull request
May 8, 2019
… - part 2) (qmk#5783) * Initial conversion of the rgb_led struct * Converting last keyboard & updating effects to take advantage of the new structure * New struct should not be const * Updated docs * Changing define ___ for no led to NO_LED * Missed converting some keymap usages of the old struct layout
KauyonKais
pushed a commit
to KauyonKais/qmk_firmware
that referenced
this pull request
May 8, 2019
… - part 2) (qmk#5783) * Initial conversion of the rgb_led struct * Converting last keyboard & updating effects to take advantage of the new structure * New struct should not be const * Updated docs * Changing define ___ for no led to NO_LED * Missed converting some keymap usages of the old struct layout
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
… - part 2) (qmk#5783) * Initial conversion of the rgb_led struct * Converting last keyboard & updating effects to take advantage of the new structure * New struct should not be const * Updated docs * Changing define ___ for no led to NO_LED * Missed converting some keymap usages of the old struct layout
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
… - part 2) (qmk#5783) * Initial conversion of the rgb_led struct * Converting last keyboard & updating effects to take advantage of the new structure * New struct should not be const * Updated docs * Changing define ___ for no led to NO_LED * Missed converting some keymap usages of the old struct layout
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
… - part 2) (qmk#5783) * Initial conversion of the rgb_led struct * Converting last keyboard & updating effects to take advantage of the new structure * New struct should not be const * Updated docs * Changing define ___ for no led to NO_LED * Missed converting some keymap usages of the old struct layout
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
… - part 2) (qmk#5783) * Initial conversion of the rgb_led struct * Converting last keyboard & updating effects to take advantage of the new structure * New struct should not be const * Updated docs * Changing define ___ for no led to NO_LED * Missed converting some keymap usages of the old struct layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update of the rgb_led struct layout to a more efficient layout. This improves the key to led lookup complexity from O(n) to O(1), in addition, the usage of the data in the effects is simpler as it removes the need to hoist grabbing data from the struct to use in the effect and allows the compiler to optimize the loop easier.
Types of Changes
Issues Fixed or Closed by This PR
Checklist