Issue 497 Android policy compliance #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on and privacy policy.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| module.exports = { | |||
| Switch, | ||
| View | ||
| } from 'react-native' | ||
| import React from 'react'; |
There was a problem hiding this comment.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
mcbouslog
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Looking good to me! Tested locally and confirmed UX is as expected.
Non-blocking note - I noticed in About the Zooniverse and Publications in the upper left there's a carrot I can press to go back, but in Settings and Notifications there's the Zooniverse icon that doesn't do anything when I press it. Just noting, disregard if intentional, not blocking if something to revisit subsequent to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
Designs: https://www.figma.com/file/QC931orjhCdGoQogVg7iDZ/Mobile-App?type=design&node-id=237-1158&mode=design&t=mYaV3cg9TSzbCigN-0
Summary: Updates to the side drawer menu and settings page to support external links for account deletion and privacy policy.