Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken newline functionality for markdown #464

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Fixed broken newline functionality for markdown #464

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
91adb91
Added additional markdown library to handle text
coryzoon Oct 10, 2023
ef3578d
Add function to double the newline character to fix issue 412.
coryzoon Oct 11, 2023
aeadac2
Fix spacing.
coryzoon Oct 11, 2023
e0e0114
Revert "Fix spacing."
coryzoon Oct 11, 2023
837c971
Revert "Add function to double the newline character to fix issue 412."
coryzoon Oct 11, 2023
d7aa008
Added function to double the newline character and fix issue 412.
coryzoon Oct 11, 2023
38d2108
Merge branch 'master' into bugfix/issues-412-markdown-newline-character
coryzoon Oct 11, 2023
bb6099c
Refactored addLineBreak() to be more concise.
coryzoon Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/common/SizedMarkdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ class SizedMarkdown extends Component {
})
}

// Fixes: https://github.com/zooniverse/mobile/issues/412
addLineBreak(content) {
return content.replace(/\n/g, (n) => n + n);
}

render() {
const { viewDimensions } = this.state

Expand Down Expand Up @@ -77,7 +82,7 @@ class SizedMarkdown extends Component {
return (
<View onLayout={this.onViewLayout}>
<Markdown rules={markdownImageRule} styles={customStyles}>
{ this.props.children }
{this.addLineBreak(this.props.children)}
</Markdown>
</View>
)
Expand Down