Fixed broken newline functionality for markdown #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbouslog
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
This looks good 👍 , fixes the content issue noted, as confirmed locally with staging workflow https://master.pfe-preview.zooniverse.org/lab/1974/workflows/3619?env=staging.
Sorry it's trivial but could you change the PR name? These changes don't include any library change.
coryzoon
changed the title
|
@mcbouslog Sure thing, I've updated the PR name. The ticket originally started out as a library change but didn't end up needing it. I must've forgotten to update the PR name, thanks! |
This was referenced Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
Passes markdown content to a function that searches for newline characters \n and if they exist doubles them to \n\n to ensure they break the line.
Solution comes from:
CharlesMangwa/react-native-simple-markdown#68 (comment)