-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib-user: Refactor link urls for internal testing #6131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion and a question. Otherwise LGTM!
packages/lib-user/src/components/GroupStats/helpers/getHeaderItems.js
Outdated
Show resolved
Hide resolved
@@ -14,7 +14,7 @@ describe('components > UserStats > TopProjects', function () { | |||
expect(screen.getByText('Top Projects')).to.be.ok() | |||
}) | |||
|
|||
it('should show a "see more" link', function () { | |||
it.skip('should show a "see more" link', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this one is still getting skipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! Eventually there'll be an All Projects page and the "see more" link will be added back and this test can be re-enabled. I've added a comment in the test code accordingly (should have done initially 🤦♂️ )
Package
Describe your changes
How to Review
Helpful explanations that will make your reviewer happy:
yarn build
thenyarn start
(or for staging resources runyarn dev
)/users/[login]/stats
)/users/[login]/groups
)/groups/[group ID]
)/groups/[group ID]/contributors
)Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Refactoring