Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-user: Refactor link urls for internal testing #6131

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Jun 13, 2024

Package

  • lib-user

Describe your changes

How to Review

Helpful explanations that will make your reviewer happy:

  • What Zooniverse project should my reviewer use to review UX?
  • What user actions should my reviewer step through to review this PR?
    • from app-root, for production resources, run yarn build then yarn start (or for staging resources run yarn dev)
    • check links (and links that look like buttons) on:
      • user stats page (/users/[login]/stats)
      • my groups page (/users/[login]/groups)
      • group stats page (/groups/[group ID])
      • group contributors page (/groups/[group ID]/contributors)
  • Which storybook stories should be reviewed? n/a
  • Are there plans for follow up PR’s to further fix this bug or develop this feature? see linked GitHub project

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)
  • FEM works in a mobile browser

General UX

Refactoring

  • The PR creator has described the reason for refactoring
  • The refactored component(s) continue to work as expected

@mcbouslog mcbouslog requested a review from a team June 13, 2024 15:00
@kieftrav kieftrav requested review from kieftrav and removed request for a team June 13, 2024 15:07
@coveralls
Copy link

Coverage Status

coverage: 79.209% (+0.01%) from 79.195%
when pulling fdf3a12 on lib-user_links
into 48007fa on master.

Copy link
Contributor

@kieftrav kieftrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion and a question. Otherwise LGTM!

@@ -14,7 +14,7 @@ describe('components > UserStats > TopProjects', function () {
expect(screen.getByText('Top Projects')).to.be.ok()
})

it('should show a "see more" link', function () {
it.skip('should show a "see more" link', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this one is still getting skipped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question! Eventually there'll be an All Projects page and the "see more" link will be added back and this test can be re-enabled. I've added a comment in the test code accordingly (should have done initially 🤦‍♂️ )

@github-actions github-actions bot added the approved This PR is approved for merging label Jun 14, 2024
@coveralls
Copy link

Coverage Status

coverage: 79.225% (+0.03%) from 79.192%
when pulling 23aa06a on lib-user_links
into cdd1c1c on master.

@mcbouslog mcbouslog merged commit 1a9e6c2 into master Jun 14, 2024
10 checks passed
@mcbouslog mcbouslog deleted the lib-user_links branch June 14, 2024 18:10
@coveralls
Copy link

Coverage Status

coverage: 79.184% (-0.008%) from 79.192%
when pulling 26bd531 on lib-user_links
into cdd1c1c on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants