lib-user: Refactor link urls for internal testing (#6131)

* Refactor link urls for internal testing * Add BASE_URL const to getHeaderItems
zooniverse · Jun 14, 2024 · 1a9e6c2 · 1a9e6c2
1 parent cdd1c1c
commit 1a9e6c2
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 27 deletions.
diff --git a/packages/lib-user/src/components/GroupStats/helpers/getHeaderItems.js b/packages/lib-user/src/components/GroupStats/helpers/getHeaderItems.js
@@ -11,6 +11,8 @@ import {
   HeaderToast
 } from '@components/shared'
 
+const BASE_URL = 'https://fe-root.preview.zooniverse.org'
+
 async function handleLeaveGroup({
   login,
   membershipId
@@ -21,7 +23,7 @@ async function handleLeaveGroup({
   const deleteMembershipResponse = await deletePanoptesMembership({ membershipId })
   if (!deleteMembershipResponse.ok) return
 
-  window.location.href = `https://www.zooniverse.org/users/${login}`
+  window.location.href = '/'
 }
 
 function getHeaderItems({
@@ -46,14 +48,14 @@ function getHeaderItems({
         label='Share Group'
         message='Group Link Copied!'
         primaryItem={true}
-        textToCopy={`https://www.zooniverse.org/groups/${group.id}`}
+        textToCopy={`${BASE_URL}/groups/${group.id}`}
       />
     )
   } else {
     headerItems.PrimaryHeaderItem = (
       <HeaderLink
-        href={`https://www.zooniverse.org/users/${authUser?.login}`}
-        label='back to profile'
+        href={`/users/${authUser?.login}/groups`}
+        label='all my groups'
         primaryItem={true}
       />
     )
@@ -74,7 +76,7 @@ function getHeaderItems({
         icon={<Layer color='white' size='small' />}
         label='Share Group'
         message='Group Link Copied!'
-        textToCopy={`https://www.zooniverse.org/groups/${group.id}`}
+        textToCopy={`${BASE_URL}/groups/${group.id}`}
       />
     )
   }
@@ -86,14 +88,14 @@ function getHeaderItems({
         icon={<Link color='white' size='small' />}
         label='Copy Join Link'
         message='Join Link Copied!'
-        textToCopy={`https://www.zooniverse.org/groups/${group.id}?join_token=${group.join_token}`}
+        textToCopy={`${BASE_URL}/groups/${group.id}?join_token=${group.join_token}`}
       />,
       <HeaderToast
         key='share-group-toast'
         icon={<Layer color='white' size='small' />}
         label='Share Group'
         message='Group Link Copied!'
-        textToCopy={`https://www.zooniverse.org/groups/${group.id}`}
+        textToCopy={`${BASE_URL}/groups/${group.id}`}
       />,
       <HeaderButton
         key='manage-group-button'

diff --git a/packages/lib-user/src/components/GroupStats/helpers/getHeaderItems.spec.js b/packages/lib-user/src/components/GroupStats/helpers/getHeaderItems.spec.js
@@ -25,7 +25,7 @@ describe('components > GroupStats > getHeaderItems', function () {
     describe('with group member', function () {
       it('should return a link to the user profile', function () {
         const result = getHeaderItems({ authUser, group: privateAggOnly, membership: groupMember })
-        expect(result.PrimaryHeaderItem.props.label).to.equal('back to profile')
+        expect(result.PrimaryHeaderItem.props.label).to.equal('all my groups')
       })
 
       it('should return a leave group button', function () {
@@ -37,7 +37,7 @@ describe('components > GroupStats > getHeaderItems', function () {
     describe('with group admin', function () {
       it('should return a link to the user profile', function () {
         const result = getHeaderItems({ authUser, group: privateAggOnly, membership: groupAdmin })
-        expect(result.PrimaryHeaderItem.props.label).to.equal('back to profile')
+        expect(result.PrimaryHeaderItem.props.label).to.equal('all my groups')
       })
 
       it('should return a copy join link toast', function () {
@@ -71,7 +71,7 @@ describe('components > GroupStats > getHeaderItems', function () {
     describe('with group member', function () {
       it('should return a link to the user profile', function () {
         const result = getHeaderItems({ authUser, group: publicShowAll, membership: groupMember })
-        expect(result.PrimaryHeaderItem.props.label).to.equal('back to profile')
+        expect(result.PrimaryHeaderItem.props.label).to.equal('all my groups')
       })
 
       it('should return a leave group button', function () {
@@ -88,7 +88,7 @@ describe('components > GroupStats > getHeaderItems', function () {
     describe('with group admin', function () {
       it('should return a link to the user profile', function () {
         const result = getHeaderItems({ authUser, group: publicShowAll, membership: groupAdmin })
-        expect(result.PrimaryHeaderItem.props.label).to.equal('back to profile')
+        expect(result.PrimaryHeaderItem.props.label).to.equal('all my groups')
       })
 
       it('should return a copy join link toast', function () {

diff --git a/packages/lib-user/src/components/MyGroups/MyGroupsContainer.js b/packages/lib-user/src/components/MyGroups/MyGroupsContainer.js
@@ -64,15 +64,13 @@ function MyGroupsContainer({
       <Layout
         primaryHeaderItem={
           <HeaderLink
-            href={`https://www.zooniverse.org/users/${login}`}
-            label='back to profile'
+            href='/'
+            label='back'
             primaryItem={true}
           />
         }
       >
         <ContentBox
-          linkLabel='Learn more about Groups'
-          linkProps={{ href: '/groups' }}
           title='My Groups'
           pad={{ horizontal: '60px', vertical: '30px' }}
         >

diff --git a/packages/lib-user/src/components/UserStats/UserStats.js b/packages/lib-user/src/components/UserStats/UserStats.js
@@ -43,8 +43,8 @@ function UserStats({
     <Layout
       primaryHeaderItem={
         <HeaderLink
-          href={`https://www.zooniverse.org/users/${user?.login}`}
-          label='back to profile'
+          href='/'
+          label='back'
           primaryItem={true}
         />
       }

diff --git a/packages/lib-user/src/components/shared/ContentBox/ContentBox.stories.js b/packages/lib-user/src/components/shared/ContentBox/ContentBox.stories.js
@@ -82,8 +82,6 @@ export const TopProjectsFull = {
 export const TopProjectsFullWithFewerProjects = {
   render: () => (
     <ContentBox
-      linkLabel='See more'
-      linkProps={{ href: 'https://www.zooniverse.org/projects' }}
       title='Top Projects'
     >
       <Box
@@ -103,8 +101,6 @@ export const TopProjectsFullWithFewerProjects = {
 export const TopProjectsGrid = {
   render: () => (
     <ContentBox
-      linkLabel='See more'
-      linkProps={{ href: 'https://www.zooniverse.org/projects' }}
       title='Top Projects'
       width='625px'
     >
@@ -123,7 +119,7 @@ export const TopContributors = {
   render: () => (
     <ContentBox
       linkLabel='See all contributors and detailed stats'
-      linkProps={{ href: 'https://www.zooniverse.org/groups/12345/contributors' }}
+      linkProps={{ href: '/groups/12345/contributors' }}
       title='Top Contributors'
       width='625px'
     >

diff --git a/packages/lib-user/src/components/shared/HeaderToast/HeaderToast.stories.js b/packages/lib-user/src/components/shared/HeaderToast/HeaderToast.stories.js
@@ -33,7 +33,7 @@ export const CopyJoinLink = {
     icon: <Link color='white' size='small' />,
     label: 'Copy Join Link',
     message: 'Join Link Copied!',
-    textToCopy: 'groups/1234?join_token=56789'
+    textToCopy: 'https://www.zooniverse.org/groups/1234?join_token=56789'
   }
 }
 
@@ -42,6 +42,6 @@ export const ShareGroup = {
     icon: <Layer color='white' size='small' />,
     label: 'Share Group',
     message: 'Group Link Copied!',
-    textToCopy: 'zooniverse.org/groups/1234'
+    textToCopy: 'https://www.zooniverse.org/groups/1234'
   }
 }
diff --git a/packages/lib-user/src/components/shared/TopProjects/TopProjects.js b/packages/lib-user/src/components/shared/TopProjects/TopProjects.js
@@ -70,8 +70,6 @@ function TopProjects({
 
   return (
     <ContentBox
-      linkLabel='See more'
-      linkProps={{ href: 'https://www.zooniverse.org/projects' }}
       title='Top Projects'
     >
       <Container>

diff --git a/packages/lib-user/src/components/shared/TopProjects/TopProjects.spec.js b/packages/lib-user/src/components/shared/TopProjects/TopProjects.spec.js
@@ -14,7 +14,9 @@ describe('components > shared > TopProjects', function () {
     expect(screen.getByText('Top Projects')).to.be.ok()
   })
 
-  it('should show a "see more" link', function () {
+  // temporarily skipping until the new All Projects page is created
+  // once the All Projects page is created the "see more" to that page will be added and this test can be enabled
+  it.skip('should show a "see more" link', function () {
     render(<DefaultStory />)
 
     expect(screen.getByRole('link', { name: 'See more' })).to.be.ok()