Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert minimum text length for collections search. #7150

Closed
wants to merge 1 commit into from

Conversation

eatyourgreens
Copy link
Contributor

Since #7124, collections search no longer finds short collection names for Gravity Spy.

Staging branch URL: https://pr-{NUMBER}.pfe-preview.zooniverse.org

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

Since zooniverse#7124, collections search no longer finds short collection names for Gravity Spy.
@coveralls
Copy link

Coverage Status

coverage: 56.819%. remained the same
when pulling 84f447d on eatyourgreens:patch-1
into c0e17f9 on zooniverse:master.

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Aug 12, 2024

This PR might not be needed:

With PR#7124 applied and two-character collection names allowed, I got into a situation where my two-character collection was totally unreachable for adding another subject (until I renamed it). There was nothing I could enter into the dialog that could have found it, since even entering its full exact title no longer launched a search, and it had dropped off the end of my "100 most recently created" years ago.
On the other hand, I don't think this case exists very often, and I've worked around it for myself.
So it's kind of important, but not urgent at all. I still believe enforcing longer titles would be better than reverting PR#7124, even if it takes a while.

https://www.zooniverse.org/talk/17/3411492?comment=5603804

It's only needed if you have:

  • more than 100 collections.
  • collections with 2 or 3-letter names that can't be found by filtering the names of your most recent 100 collections.

@mcbouslog mcbouslog self-assigned this Aug 12, 2024
@mcbouslog
Copy link
Contributor

Thank you @eatyourgreens for this quick revert PR! As you note, per the linked Talk post, while there's an issue with collections with display name's that are 3 characters or less that are not in a user's most recent 100 collections, I think it's such an edge case I'm going to close this for now.

There haven't been other posts on the related Talk discussion and I think your related PR improved collections search for most users so much I'd rather not change things. I'm going to open new issues in PFE and FEM regarding collections search and will link to this PR and related PRs/issues. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants