Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEM Redirect for Notes from Nature - CAS Plants to Pixels #7128

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

yuenmichelle1
Copy link
Contributor

@yuenmichelle1 yuenmichelle1 commented Jun 18, 2024

Related Static PR: zooniverse/static#356

Staging branch URL: https://pr-7128.pfe-preview.zooniverse.org/
Staging URL for Project: https://pr-7128.pfe-preview.zooniverse.org/projects/md68135/notes-from-nature-cas-plants-to-pixels
Target Link: https://www.zooniverse.org/projects/md68135/notes-from-nature-cas-plants-to-pixels
Project Lab Link: https://www.zooniverse.org/lab/22907

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@coveralls
Copy link

Coverage Status

coverage: 56.991% (-0.003%) from 56.994%
when pulling 0352f08 on redirect-for-nfn-cas
into 408ffca on master.

@yuenmichelle1 yuenmichelle1 requested a review from mcbouslog June 18, 2024 21:26
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@yuenmichelle1 yuenmichelle1 merged commit e73d209 into master Jun 20, 2024
5 checks passed
@yuenmichelle1 yuenmichelle1 deleted the redirect-for-nfn-cas branch June 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants