Add Venda and Tsonga language codes #6729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels and ISO 693-3 language codes for Tshivenḓa and Xitsonga.
eatyourgreens
commented
Jul 20, 2023
lcjohnso
approved these changes
Jul 20, 2023
| @@ -118,6 +119,7 @@ const languages = [ | |||
| { value: 'vi', label: 'Vietlabelse' }, | |||
| { value: 'cy', label: 'Welsh' }, | |||
| { value: 'wo-sn', label: 'Wolof (Senegal)' }, | |||
| { value: 'ts', label: 'Xitsonga'}, | |||
There was a problem hiding this comment.
Suggested change
| { value: 'ts', label: 'Xitsonga'}, | |
| { value: 'ts', label: 'Tsonga'}, |
| @@ -108,6 +108,7 @@ const languages = [ | |||
| { value: 'te', label: 'Telugu' }, | |||
| { value: 'th', label: 'Thai' }, | |||
| { value: 'bo-cn', label: 'Tibetan (PRC)' }, | |||
| { value: 've', label: 'Tshivenḓa' }, | |||
There was a problem hiding this comment.
Suggested change
| { value: 've', label: 'Tshivenḓa' }, | |
| { value: 've', label: 'Venda' }, |
|
The names here are the language names used by our South African colleagues, so I’ll leave the choice to them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels and 2-letter ISO 639 language codes for Tshivenḓa and Xitsonga.
Staging branch URL: https://pr-6729.pfe-preview.zooniverse.org