Rewrite router to NOT use CoffeeScript #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunanoordin
commented
Oct 29, 2021
|
Nothing is broken in projects, Talk or the project builder, after some very quick, initial clicking of links on the staging site. |
shaunanoordin
commented
Oct 29, 2021
| <Route path="organization-status/:owner/:name" component={OrganizationStatus} /> | ||
| </Route> | ||
|
|
||
| <Route path="todo" component={() => <div className="content-container"><i className="fa fa-cogs"></i> TODO</div>} /> |
There was a problem hiding this comment.
No, seriously, what is this?
There was a problem hiding this comment.
shaunanoordin
commented
Oct 29, 2021
| </Route> | ||
|
|
||
| <Route path="todo" component={() => <div className="content-container"><i className="fa fa-cogs"></i> TODO</div>} /> | ||
| <Route path="dev/workflow-tasks-editor" component={require('./components/workflow-tasks-editor')} /> |
There was a problem hiding this comment.
What is this?? https://www.zooniverse.org/dev/workflow-tasks-editor
Co-Authored-By: Jim O'Donnell <[email protected]>
PR Update
Thanks, Jim! |
eatyourgreens
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
CoffeeScript is bad. We want basic JavaScript. This PR refactors the PFE router to not use the bad CoffeeScript.
app/router.cjsxis nowapp/router.jsxTesting
❗ This affects a foundational aspect of PFE, so please double check everything!
Testing URL: https://pr-6041.pfe-preview.zooniverse.org
Expected behaviour:
Status
Ready for review. Required for #6037
Note that I didn't optimise or future-proof anything. If you want to, go ahead and make an in-line suggestion and I'll commit them to the branch. 👌