Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of survey task example photos #5533

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Oct 25, 2019

Staging branch URL: https://pr-5533.pfe-preview.zooniverse.org

Towards #5531.

Add more descriptive labels to the controls for example images.
Make the example image a live region.
Lint survey task components.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

Add more descriptive labels to the controls for example images.
Make the example image a live region.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 49.163% when pulling c366034 on a11y-survey-task into e55e021 on master.

@eatyourgreens eatyourgreens requested a review from a team October 25, 2019 10:55
@simensta simensta self-requested a review October 29, 2019 14:04
Copy link
Contributor

@simensta simensta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this branch on the following systems:
OS X Catalina | Safari 13.0.2
OS X Catalina | Chrome 77
OS X Catalina | Firefox 69.0.2
iPhone XS Max iOS 12.0 | mobile_Chrome
Windows 10 | Edge 18.0

In Chrome and Safari, I was able to hear the changes for example images when using VoiceOver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants