Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to write links in Markdown #3958

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Jul 28, 2017

Talk discussion about writing links in Markdown implies the instructions are confusing

Describe your changes.
Removes the 'URL shortening' wording and tries to clarify internal vs. external links

Review Checklist

Optional

  • If it's a new component, is it in ES6? Is it clear of warnings from ESLint?
  • Have you replaced any ChangeListener or PromiseRenderer components with code that updates component state?
  • If changes are made to the classifier, does the dev classifier still work?
  • Have you added in flow type annotations?

Copy link
Contributor

@camallen camallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Jul 28, 2017

Leaving the branch here as a reminder until changes have been copied to zooniverse/markdownz#58

@jelliotartz
Copy link
Contributor

Thanks @eatyourgreens, changes copied into zooniverse/markdownz#58, closing this branch now.

@jelliotartz jelliotartz deleted the markdown-help-changes branch August 8, 2017 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants