Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown project prop #1444

Merged
merged 4 commits into from
Aug 26, 2015
Merged

Markdown project prop #1444

merged 4 commits into from
Aug 26, 2015

Conversation

aweiksnar
Copy link
Contributor

@brian-c
Copy link
Contributor

brian-c commented Aug 25, 2015

Looks like ^123 isn't picked up, and @name/project^123 only links the user.

See #/projects/brian-testing/ghosts/talk/53/78?comment=466

@aweiksnar
Copy link
Contributor Author

Yeah it'll need an S prefix now to match. That was my mistake for initially matching cases without the resource type prefix. See zooniverse/markdownz#11

@brian-c
Copy link
Contributor

brian-c commented Aug 26, 2015

Cool, got it now. Anything need to happen before we can use this in Talk comments?

@aweiksnar
Copy link
Contributor Author

Should be good to go with the markdowz update, Mentions will just have to look something like S123123

@brian-c
Copy link
Contributor

brian-c commented Aug 26, 2015

It doesn't look like the project is included in the comment-preview module, so @u/p^S123 works but ^S234 just turns into "234" for some reason (where'd the "^S" go, anyway?).

@aweiksnar
Copy link
Contributor Author

I just tested locally - ^S123123 should be working ok in project talks, but in zooniverse-wide talk it needs to be project specified. It'll currently fall back to just the id so there's not a weird caret in the text if the comment happens to be rendered outside of the context of the project

@brian-c
Copy link
Contributor

brian-c commented Aug 26, 2015

Can I see a link to a project comment on dev? I must be doing something wrong here.

@aweiksnar
Copy link
Contributor Author

Ah so sorry! I was looking at a different preview. Now I see where you're not seeing it: Will push up a fix in a min

@aweiksnar
Copy link
Contributor Author

I just pushed up a change removing that comment-preview module in favor of just markdown, since it was a waste of a class. Deployed here for testing

@brian-c
Copy link
Contributor

brian-c commented Aug 26, 2015

Glorious now, thanks!

brian-c added a commit that referenced this pull request Aug 26, 2015
@brian-c brian-c merged commit df19acb into master Aug 26, 2015
@brian-c brian-c deleted the markdown-project-prop branch August 26, 2015 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants