CI Attempt 2 #13
Closed
CI Attempt 2 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnecessary in dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #12
Doing a different approach to CI, as am redoing the steps inside the workflow as opposed to building the dockerfile and running it.
Upside is that docker doesn't run inside the CI, downside is that if build steps have to change, they must be changed in both the workflow file and the dockerfile as opposed to only modifying the dockerfile.
(imo i do prefer the other docker-based pr since it takes less to maintain, as any changes to the dockerfile also get reflected in the ci)
Description
Adds a GitHub Actions workflow to automatically build a CIA upon commits to n3ds-main
Also fixes a perms issue on the scripts that prevents the Dockerfile from being built
Also fixes bannertool download in the Dockerfile
Purpose
Would be useful for releasing nightly builds of this app without having to compile it yourself. Could also be integrated into Universal Updater by having it create a "nightly" release in GitHub Releases, tho that isn't currently implemented in this PR.