Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker-based CI to build CIAs #12

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

RoblKyogre
Copy link

@RoblKyogre RoblKyogre commented Mar 6, 2024

Alternate to #13

(do prefer this pr personally)

Description
Adds a GitHub Actions workflow to automatically build a CIA upon commits to n3ds-main
Also fixes a perms issue on the scripts that prevents the Dockerfile from being built
Also updates the dockerfile to download a fork of bannertool
And also changes the dockerfile to use an image that already has devkitArm set up

Purpose
Would be useful for releasing nightly builds of this app without having to compile it yourself. Could also be integrated into Universal Updater by having it create a "nightly" release in GitHub Releases, tho that isn't currently implemented in this PR.

@RoblKyogre RoblKyogre marked this pull request as ready for review March 6, 2024 10:52
@RoblKyogre
Copy link
Author

RoblKyogre commented Mar 8, 2024

Closing, seems like devkitpro blocks CI from using dkp-pacman
will attempt again using one of their containers

@RoblKyogre RoblKyogre closed this Mar 8, 2024
@RoblKyogre RoblKyogre mentioned this pull request Mar 8, 2024
@RoblKyogre
Copy link
Author

actually, just realized that this doesn't necessarily have to be closed yet...
could change the dockerfile to be based on dkp's container instead

@RoblKyogre RoblKyogre reopened this Mar 8, 2024
@RoblKyogre RoblKyogre marked this pull request as draft March 8, 2024 06:34
@RoblKyogre RoblKyogre marked this pull request as ready for review March 8, 2024 07:11
@RoblKyogre RoblKyogre closed this Mar 11, 2024
@RoblKyogre RoblKyogre reopened this Mar 11, 2024
@RoblKyogre
Copy link
Author

accidentally merged another branch into this one, reverted the merge commit that did it (was worried it would fuck things up which is why i closed the pr before figuring out how to revert it)

@RoblKyogre
Copy link
Author

gonna be squashing these commits in a while (once i get back on my laptop)

@RoblKyogre RoblKyogre changed the title Add CI to build a CIA upon commits Add Docker-based CI to build CIAs Mar 11, 2024
@zoeyjodon
Copy link
Owner

Awesome! I've wanted to add this for a while, but kept putting it off. LGTM!

@zoeyjodon zoeyjodon merged commit d77c4b1 into zoeyjodon:n3ds-main Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants