-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observable#subscribe w/ callbacks #257
Comments
Some months ago |
Is that really API breaking changes? I See it more like an API addition. var sub = Observable.prototype.subscribe;
Observable.prototype.subscribe = function(onNext, onError, onComplete) {
if (onNext instanceof Function) {
return sub.call(this, {
next: onNext,
error: onError,
complete: onComplete
});
} else {
return sub.call(this, onNext);
}
}; Or do im miss somthing here right now? |
For example, in |
Added to v3 branch. |
The current Observable proposal allows two different ways to call
subscribe
: with an observer object, or via callbacks. The later doesn't seem to be supported by Core-js.The text was updated successfully, but these errors were encountered: