Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable: Subscription and SubscriptionObserver prototypes lack a closed getter. #276

Closed
jasmith79 opened this issue Feb 2, 2017 · 2 comments
Labels

Comments

@jasmith79
Copy link

jasmith79 commented Feb 2, 2017

Per the proposal both of the following console.logs should work (simplified example):

let obs = new Observable(observer => { console.log(observer.closed); }); // undefined
let subs = obs.subscribe({});
console.log(subs.closed);  // undefined

console.log("closed" in subs); // false

This is part of the test conformance suite and it should return false or true depending. Looking through the source code it doesn't seem implemented. Seems like a trivial PR if you'd like me to do it.

@zloirock
Copy link
Owner

zloirock commented Aug 25, 2017

I'll try to add it to core-js@3 because actual Observable has many breaking changes.

@zloirock
Copy link
Owner

zloirock commented Dec 8, 2017

Added to v3 branch.

@zloirock zloirock closed this as completed Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants