Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): fix ObservableQuery.lifecycle for cache only results #777

Merged

Conversation

blaugold
Copy link
Contributor

Fix for #771

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #777 (f44b479) into beta (2efce9f) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #777   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files          35       35           
  Lines        1354     1356    +2     
=======================================
+ Hits          670      671    +1     
- Misses        684      685    +1     
Flag Coverage Δ
graphql_client 52.74% <66.66%> (-0.01%) ⬇️
graphql_flutter 31.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/graphql/lib/src/core/observable_query.dart 44.88% <66.66%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2efce9f...f44b479. Read the comment docs.

Copy link
Collaborator

@micimize micimize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – I might have preferred to base the condition on the policy itself, but idk if that would be better

@HofmannZ
Copy link
Member

🎉 This PR is included in version 4.0.0-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@blaugold blaugold deleted the fix/observable-query-fetch-from-cache branch January 5, 2021 11:21
@HofmannZ
Copy link
Member

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants