fix(): fix ObservableQuery.lifecycle for cache only results

zino-hofmann · Nov 30, 2020 · f44b479 · f44b479
1 parent 2efce9f
commit f44b479
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/packages/graphql/lib/src/core/observable_query.dart b/packages/graphql/lib/src/core/observable_query.dart
@@ -187,11 +187,16 @@ class ObservableQuery {
         queryManager.fetchQueryAsMultiSourceResult(queryId, options);
     latestResult ??= allResults.eagerResult;
 
-    // if onData callbacks have been registered,
-    // they are waited on by default
-    lifecycle = _onDataCallbacks.isNotEmpty
-        ? QueryLifecycle.sideEffectsPending
-        : QueryLifecycle.pending;
+    if (allResults.networkResult == null) {
+      // This path is only possible for cacheFirst and cacheOnly fetch policies.
+      lifecycle = QueryLifecycle.completed;
+    } else {
+      // if onData callbacks have been registered,
+      // they are waited on by default
+      lifecycle = _onDataCallbacks.isNotEmpty
+          ? QueryLifecycle.sideEffectsPending
+          : QueryLifecycle.pending;
+    }
 
     if (options.pollInterval != null && options.pollInterval > Duration.zero) {
       startPolling(options.pollInterval);