Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove additional metric_type definition from diskann_config #674

Merged

Conversation

alwayslove2013
Copy link
Collaborator

just BaseConfig is ok.

KNOHWERE_DECLARE_CONFIG(BaseConfig) {
KNOWHERE_CONFIG_DECLARE_FIELD(metric_type)
.set_default("L2")
.description("metric type")
.for_train_and_search()
.for_iterator()
.for_deserialize();

Copy link

mergify bot commented Jul 1, 2024

@alwayslove2013 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@cqy123456
Copy link
Collaborator

/lgtm

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (3c46f4c) to head (99ecb02).
Report is 106 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #674       +/-   ##
=========================================
+ Coverage      0   71.75%   +71.75%     
=========================================
  Files         0       69       +69     
  Lines         0     4737     +4737     
=========================================
+ Hits          0     3399     +3399     
- Misses        0     1338     +1338     

see 69 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 1, 2024
@alwayslove2013
Copy link
Collaborator Author

/kind improvement

Copy link
Collaborator

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alwayslove2013, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f595684 into zilliztech:main Jul 1, 2024
13 checks passed
xxxlzhxxx pushed a commit to xxxlzhxxx/knowhere that referenced this pull request Jul 23, 2024
alwayslove2013 added a commit that referenced this pull request Jul 25, 2024
alwayslove2013 added a commit that referenced this pull request Jul 26, 2024
* remove test case if with_cardinal: check diskann max_k < min_k (#664)

Signed-off-by: min.tian <[email protected]>

* [range search] iterator stops only if exceeds radius several times consecutively (#671)

Signed-off-by: min.tian <[email protected]>

* remove additional metric_type definition from diskann_config (#674)

Signed-off-by: min.tian <[email protected]>

* fix diskann range_search config: search_list_size should for_range_search (#694)

Signed-off-by: min.tian <[email protected]>

* range_search will early terminate with range_search_k (#700)

Signed-off-by: min.tian <[email protected]>

* add a new meta: range_search_k for range_search_k (#706)

Signed-off-by: min.tian <[email protected]>

* fix: correctly compares the size_t and int32_t (#705)

Signed-off-by: min.tian <[email protected]>

* fix bug: remove bm_25

Signed-off-by: min.tian <[email protected]>

* upgrade cardinal to poc_0725

Signed-off-by: min.tian <[email protected]>

---------

Signed-off-by: min.tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants