not check diskann range_search params max_k < min_k if with_cardinal #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alwayslove2013 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Signed-off-by: min.tian <[email protected]>
alwayslove2013
force-pushed
the
remove_diskann_test_range_search_max_k
branch
from
ec730f2 to
02a54ba
Compare
alwayslove2013
changed the title
alwayslove2013
changed the title
alwayslove2013
changed the title
alwayslove2013
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=========================================
+ Coverage 0 71.49% +71.49%
=========================================
Files 0 69 +69
Lines 0 4719 +4719
=========================================
+ Hits 0 3374 +3374
- Misses 0 1345 +1345 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alwayslove2013, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind improvement |
xxxlzhxxx
pushed a commit
to xxxlzhxxx/knowhere
that referenced
this pull request
Jul 23, 2024
…ztech#664) Signed-off-by: min.tian <[email protected]>
alwayslove2013
added a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: min.tian <[email protected]>
alwayslove2013
added a commit
that referenced
this pull request
Jul 26, 2024
* remove test case if with_cardinal: check diskann max_k < min_k (#664) Signed-off-by: min.tian <[email protected]> * [range search] iterator stops only if exceeds radius several times consecutively (#671) Signed-off-by: min.tian <[email protected]> * remove additional metric_type definition from diskann_config (#674) Signed-off-by: min.tian <[email protected]> * fix diskann range_search config: search_list_size should for_range_search (#694) Signed-off-by: min.tian <[email protected]> * range_search will early terminate with range_search_k (#700) Signed-off-by: min.tian <[email protected]> * add a new meta: range_search_k for range_search_k (#706) Signed-off-by: min.tian <[email protected]> * fix: correctly compares the size_t and int32_t (#705) Signed-off-by: min.tian <[email protected]> * fix bug: remove bm_25 Signed-off-by: min.tian <[email protected]> * upgrade cardinal to poc_0725 Signed-off-by: min.tian <[email protected]> --------- Signed-off-by: min.tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.