I36 remove deps #37
I36 remove deps #37
Conversation
- faster if I just test this crate alone.
- tried to implement an umbrella trait for them, but for some reason, that didn't work. - it might be worth investigating why tho
- however, when constructing an `EthereumType` from an integer, a reference to an integer is required which might be a bit inconvenient.
| /// | ||
| /// # Panics | ||
| /// | ||
| /// Panics if the input data doesn't fit into the type, i.e. `N < L`. |
There was a problem hiding this comment.
Isn't it a prob;em in case of wasm? I guess in case of panic the caller side won't be notified about the panic, isn't it?
There was a problem hiding this comment.
Yeah, I guess, that's right, but this function was specifically written like this. The aim is to have an unchecked conversion function that doesn't return a Result, so it is faster and more convenient to use. This comes at the cost that the user is responsible to ensure the conversion never panics.
On the other hand, there is a try_from_int function, that returns a result which can be used alternatively.
- Untrack `www` folder - show decimal equivalent of some hex numbers
|
Found a bug: |
`Parameter` stores data in a `H256` type, but it wasn't converted to an `Address`, when displaying it. This means, that instead of 20 bytes, 32 bytes were displayed.
|
Decline because the new PR contains these changes as well. |
Removed many dependencies in order to resolve #36
This PR possibly resolves #32 as well (this might need more testing)