Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease dependency count as much as possible #36

Closed
9 tasks done
PopcornPaws opened this issue May 11, 2021 · 0 comments · Fixed by #38
Closed
9 tasks done

Decrease dependency count as much as possible #36

PopcornPaws opened this issue May 11, 2021 · 0 comments · Fixed by #38
Assignees
@PopcornPaws
Labels
enhancement New feature or request

Comments

@PopcornPaws
Copy link
Member

PopcornPaws commented May 11, 2021 •
edited
Loading

Description

It is desirable to decrease the number of external dependencies in order to simplify the code and increase wasm compatibility.

Underlying issue

When compiling ethane to wasm, the wasm binary imports C-functions from "env", which are not supported yet, see this issue.

Plan

  • remove crates like
    • ethereum-types
    • funty
    • logging
    • thiserror
    • hex
    • byteorder
  • use tiny-keccak everywhere (it's more lightweight)
  • replace ureq and http by reqwest with feature = ["blocking"] for blocking http requests.
@PopcornPaws PopcornPaws added the enhancement New feature or request label May 11, 2021
@PopcornPaws PopcornPaws self-assigned this May 11, 2021
@PopcornPaws PopcornPaws mentioned this issue May 14, 2021
Closed
@PopcornPaws PopcornPaws mentioned this issue May 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PopcornPaws PopcornPaws

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

I26 wasm add async zgendao/ethane
I36 remove deps zgendao/ethane
1 participant
@PopcornPaws