Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v3.5-branch] net: ip: icmp: Cleanup packet on failed priority check #65826

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[Backport v3.5-branch] net: ip: icmp: Cleanup packet on failed priority check #65826

merged 1 commit into from
Dec 1, 2023

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Nov 27, 2023 •
edited by pdgendt
Loading

Backport 473cc03 from #65737.

Fixes #65876

@pdgendt @github-actions
net: ip: icmp: Cleanup packet on failed priority check
814f6ed 
A network memory leak would occur if the priority check fails.

Signed-off-by: Pieter De Gendt <[email protected]>
(cherry picked from commit 473cc03)
@zephyrbot zephyrbot added Backport Backport PR and backport failure issues area: Networking labels Nov 27, 2023
@jukkar
Copy link
Member

jukkar commented Nov 28, 2023

I just wonder who submitted this, it requires some tweaking to pass checks.

@henrikbrixandersen
Copy link
Member

@pdgendt This requires a bug report in order to be backported.

@pdgendt
Copy link
Collaborator

pdgendt commented Nov 28, 2023 •
edited
Loading

I just wonder who submitted this, it requires some tweaking to pass checks.

It was a change introduced between 3.4 and 3.5, so it made sense to backport it.

@pdgendt This requires a bug report in order to be backported.

I can create it, but how do I set the "Fixed" handle to this issue?

@henrikbrixandersen
Copy link
Member

I can create it, but how do I set the "Fixed" handle to this issue?

If you create the issue, I can do the linking.

@pdgendt
Copy link
Collaborator

pdgendt commented Nov 28, 2023 •
edited
Loading

@henrikbrixandersen see #65876

I can update the description myself apparently.

@pdgendt
Copy link
Collaborator

pdgendt commented Nov 29, 2023

Is the greeter action blocking this somehow? CC @kartben

@fabiobaltieri
Copy link
Member

@pdgendt we looked at this at the release meeting yesterday, it would need a rebase to pass, but we can just merge without it. We usually wait a bit longer before merging backports though so feel free to leave it as is.

@jhedberg jhedberg merged commit 60c661d into v3.5-branch Dec 1, 2023
20 of 21 checks passed
@henrikbrixandersen henrikbrixandersen mentioned this pull request Dec 4, 2023
Closed
@nashif nashif deleted the backport-65737-to-v3.5-branch branch February 13, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlubos rlubos rlubos approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@jhedberg jhedberg jhedberg approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@tbursztyka tbursztyka Awaiting requested review from tbursztyka tbursztyka is a code owner

@jukkar jukkar Awaiting requested review from jukkar jukkar is a code owner

@ssharks ssharks Awaiting requested review from ssharks

Assignees

@rlubos rlubos

Labels
area: Networking Backport Backport PR and backport failure issues
Projects
Backports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zephyrbot @jukkar @henrikbrixandersen @pdgendt @fabiobaltieri @jhedberg @rlubos