net: ip: icmp: Cleanup packet on failed priority check

A network memory leak would occur if the priority check fails. Signed-off-by: Pieter De Gendt <[email protected]>
zephyrproject-rtos · Nov 27, 2023 · 473cc03 · 473cc03
1 parent 411731f
commit 473cc03
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/subsys/net/ip/icmp.c b/subsys/net/ip/icmp.c
@@ -149,7 +149,8 @@ static int send_icmpv4_echo_request(struct net_icmp_ctx *ctx,
 	    params->priority >= NET_MAX_PRIORITIES) {
 		NET_ERR("Priority %d is too large, maximum allowed is %d",
 			params->priority, NET_MAX_PRIORITIES - 1);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto drop;
 	}
 
 	if (params->priority < 0) {
@@ -269,7 +270,8 @@ static int send_icmpv6_echo_request(struct net_icmp_ctx *ctx,
 	    params->priority >= NET_MAX_PRIORITIES) {
 		NET_ERR("Priority %d is too large, maximum allowed is %d",
 			params->priority, NET_MAX_PRIORITIES - 1);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto drop;
 	}
 
 	if (params->priority < 0) {