Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrfs: GDPWR service: Renaming and adding new power domains #261

Closed
wants to merge 1 commit into from
Closed

nrfs: GDPWR service: Renaming and adding new power domains #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions nrfs/include/internal/services/nrfs_gdpwr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ extern "C" {

/** @brief Power domain selection */
typedef enum __NRFS_PACKED {
GDPWR_POWER_DOMAIN_ACTIVE_FAST,
GDPWR_POWER_DOMAIN_ACTIVE_SLOW,
GDPWR_POWER_DOMAIN_MAIN_SLOW
GDPWR_GD_FAST_ACTIVE_0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be numbered like here to allow backwards compatibility if there is changes in the future. This is now leading to a breaking change which in theory could have been avoided
https://github.com/zephyrproject-rtos/hal_nordic/pull/263/files#diff-c22a6f2ed9dee39b4c06992d6ca2e695d842b0558ec163660a5168293a06d10eR17

GDPWR_GD_FAST_ACTIVE_1,
GDPWR_GD_FAST_MAIN,
GDPWR_GD_SLOW_ACTIVE,
GDPWR_GD_SLOW_MAIN
} gdpwr_power_domain_t;

typedef enum __NRFS_PACKED {
Expand Down