nrfs: GDPWR service: Renaming and adding new power domains #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming and adding new power domains Signed-off-by: Rafal Dyla <[email protected]>
ppelikan-nordic
force-pushed
the
gdservices
branch
from
d9bde0a to
40f81de
Compare
ppelikan-nordic
changed the title
hubertmis
approved these changes
Nov 27, 2024
| @@ -61,7 +61,8 @@ enum { | |||
| NRFS_SERVICE_ID_PMIC, | |||
| NRFS_SERVICE_ID_RESET, | |||
| NRFS_SERVICE_ID_TEMP, | |||
| NRFS_SERVICE_ID_USB | |||
| NRFS_SERVICE_ID_USB, | |||
| NRFS_SERVICE_ID_GDFS | |||
There was a problem hiding this comment.
Suggested change
| NRFS_SERVICE_ID_GDFS | |
| NRFS_SERVICE_ID_GDFS, |
and you wouldn't need to modify this line when a new service is added. Cleaner repository history.
| GDPWR_POWER_DOMAIN_ACTIVE_FAST, | ||
| GDPWR_POWER_DOMAIN_ACTIVE_SLOW, | ||
| GDPWR_POWER_DOMAIN_MAIN_SLOW | ||
| GDPWR_GD_FAST_ACTIVE_0, |
There was a problem hiding this comment.
I think these should be numbered like here to allow backwards compatibility if there is changes in the future. This is now leading to a breaking change which in theory could have been avoided
https://github.com/zephyrproject-rtos/hal_nordic/pull/263/files#diff-c22a6f2ed9dee39b4c06992d6ca2e695d842b0558ec163660a5168293a06d10eR17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.