chore(perm-checker): rename filter clause to where (#1413)

zenstackhq · May 7, 2024 · 00250ea · 00250ea
1 parent 0aa6ee9
commit 00250ea
Show file tree

Hide file tree

Showing 4 changed files with 78 additions and 78 deletions.
diff --git a/packages/runtime/src/enhancements/policy/handler.ts b/packages/runtime/src/enhancements/policy/handler.ts
@@ -41,7 +41,7 @@ type FindOperations = 'findUnique' | 'findUniqueOrThrow' | 'findFirst' | 'findFi
 // input arg type for `check` API
 type PermissionCheckArgs = {
     operation: PolicyCrudKind;
-    filter?: Record<string, number | string | boolean>;
+    where?: Record<string, number | string | boolean>;
 };
 
 /**
@@ -1466,11 +1466,11 @@ export class PolicyProxyHandler<DbClient extends DbClientContract> implements Pr
             return constraint;
         }
 
-        if (args.filter) {
+        if (args.where) {
             // combine runtime filters with generated constraints
 
             const extraConstraints: CheckerConstraint[] = [];
-            for (const [field, value] of Object.entries(args.filter)) {
+            for (const [field, value] of Object.entries(args.where)) {
                 if (value === undefined) {
                     continue;
                 }

diff --git a/packages/schema/src/plugins/enhancer/enhance/checker-type-generator.ts b/packages/schema/src/plugins/enhancer/enhance/checker-type-generator.ts
@@ -31,7 +31,7 @@ export interface ModelCheckers {
 
 function generateDataModelChecker(dataModel: DataModel) {
     return `{
-        check(args: { operation: PolicyCrudKind, filter?: ${generateDataModelArgs(dataModel)} }): Promise<boolean>
+        check(args: { operation: PolicyCrudKind, where?: ${generateDataModelArgs(dataModel)} }): Promise<boolean>
     }`;
 }
 

diff --git a/packages/server/tests/api/rpc.test.ts b/packages/server/tests/api/rpc.test.ts
@@ -146,7 +146,7 @@ describe('RPC API Handler Tests', () => {
         r = await handleRequest({
             method: 'get',
             path: '/post/check',
-            query: { q: JSON.stringify({ operation: 'read', filter: { published: false } }) },
+            query: { q: JSON.stringify({ operation: 'read', where: { published: false } }) },
             prisma: enhance(),
         });
         expect(r.status).toBe(200);
@@ -155,7 +155,7 @@ describe('RPC API Handler Tests', () => {
         r = await handleRequest({
             method: 'get',
             path: '/post/check',
-            query: { q: JSON.stringify({ operation: 'read', filter: { authorId: '1', published: false } }) },
+            query: { q: JSON.stringify({ operation: 'read', where: { authorId: '1', published: false } }) },
             prisma: enhance({ id: '1' }),
         });
         expect(r.status).toBe(200);