This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Ensure Between validator has both min and max values during construction #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] issue-125 - add unit test proving undefined index error
Builds on the tests given in zendframework#183, adding more cases, and providing a fix for the issue.
weierophinney
added a commit
that referenced
this pull request
Aug 14, 2017
Ensure Between validator has both min and max values during construction
weierophinney
added a commit
that referenced
this pull request
Aug 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #125, and proved in #183, the
Betweenvalidator had some erroneous logic for determining that both min and max values are provided during instantiation. This patch builds on the tests from #183, adding more tests, and providing a patch.The fix is scheduled for 2.10.0, as it's a slight change in behavior, albeit to fix existing bad behavior.