This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
[WIP] issue-125 - add unit test proving undefined index error #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codisart
changed the title
codisart
changed the title
weierophinney
added a commit
to weierophinney/zend-validator
that referenced
this pull request
Jul 31, 2017
[WIP] issue-125 - add unit test proving undefined index error
weierophinney
added a commit
to weierophinney/zend-validator
that referenced
this pull request
Jul 31, 2017
Builds on the tests given in zendframework#183, adding more cases, and providing a fix for the issue.
|
Incorporated into #187. |
|
@weierophinney I'm glad to have been able to help with these tests. (The least I could I do after adding a bug ^^) |
|
@codisart Thanks a ton for getting the tests started! It took me a while to untangle what you were reporting, which I did by adding more test cases... at which point, it made sense to create the new pull request, as I then had an idea how to fix it. Will definitely provide reviews in the future to allow you to do the work yourself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug
created by #174
related to #125