Fix deprecation notice with zend-expressive-router 2.4 for config driven apps

src/ApplicationConfigInjectionTrait.php

@@ -8,7 +8,6 @@
 namespace Zend\Expressive;
 
 use SplPriorityQueue;
-use Zend\Expressive\Router\Route;
 
 trait ApplicationConfigInjectionTrait
 {
@@ -152,7 +151,7 @@ public function injectRoutesFromConfig(array $config = null)
                 continue;
             }
 
-            $methods = Route::HTTP_METHOD_ANY;
+            $methods = null;
             if (isset($spec['allowed_methods'])) {
                 $methods = $spec['allowed_methods'];
                 if (! is_array($methods)) {
@@ -164,7 +163,14 @@ public function injectRoutesFromConfig(array $config = null)
             }
 
             $name  = isset($spec['name']) ? $spec['name'] : null;
-            $route = new Route($spec['path'], $spec['middleware'], $methods, $name);
+            $middleware = $this->prepareMiddleware(
+                $spec['middleware'],
+                $this->router,
+                $this->responsePrototype,
+                $this->container
+            );
+
+            $route = $this->route($spec['path'], $middleware, $methods, $name);
 
             if (isset($spec['options'])) {
                 $options = $spec['options'];
@@ -177,8 +183,6 @@ public function injectRoutesFromConfig(array $config = null)
 
                 $route->setOptions($options);
             }
-
-            $this->route($route);
         }
     }
 

test/Application/ConfigInjectionTest.php

@@ -7,6 +7,7 @@
 
 namespace ZendTest\Expressive\Application;
 
+use Interop\Http\ServerMiddleware\MiddlewareInterface;
 use PHPUnit\Framework\Assert;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Prophecy\ObjectProphecy;
@@ -58,7 +59,7 @@ public static function assertRoute($spec, array $routes)
                     return false;
                 }
 
-                if ($route->getMiddleware() !== $spec['middleware']) {
+                if (! $route->getMiddleware()) {
                     return false;
                 }
 
@@ -99,7 +100,7 @@ public static function assertPipelineContainsInstanceOf($class, $pipeline, $mess
     public function callableMiddlewares()
     {
         return [
-            ['HelloWorld'],
+            [InvokableMiddleware::class],
             [
                 function () {
                 },
@@ -115,6 +116,7 @@ function () {
      */
     public function testInjectRoutesFromConfigSetsUpRoutesFromConfig($middleware)
     {
+        $pingMiddleware = $this->prophesize(MiddlewareInterface::class)->reveal();
         $config = [
             'routes' => [
                 [
@@ -124,7 +126,7 @@ public function testInjectRoutesFromConfigSetsUpRoutesFromConfig($middleware)
                 ],
                 [
                     'path' => '/ping',
-                    'middleware' => 'Ping',
+                    'middleware' => $pingMiddleware,
                     'allowed_methods' => ['GET'],
                 ],
             ],

test/Container/ApplicationFactoryTest.php

@@ -9,6 +9,7 @@
 
 use ArrayObject;
 use Interop\Http\ServerMiddleware\DelegateInterface;
+use Interop\Http\ServerMiddleware\MiddlewareInterface;
 use PHPUnit\Framework\Assert;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Prophecy\ObjectProphecy;
@@ -80,7 +81,7 @@ public static function assertRoute($spec, array $routes)
                     return false;
                 }
 
-                if ($route->getMiddleware() !== $spec['middleware']) {
+                if (! $route->getMiddleware()) {
                     return false;
                 }
 
@@ -123,8 +124,8 @@ public function testFactoryWillPullAllReplaceableDependenciesFromContainerWhenPr
 
     public function callableMiddlewares()
     {
-        $middleware = [
-            'service-name' => 'HelloWorld',
+        $middlewareTypes = [
+            'service-name' => InvokableMiddleware::class,
             'closure' => function () {
             },
             'callable' => [InvokableMiddleware::class, 'staticallyCallableMiddleware'],
@@ -136,7 +137,7 @@ public function callableMiddlewares()
         ];
 
         foreach ($configTypes as $configType => $config) {
-            foreach ($middleware as $middlewareType => $middleware) {
+            foreach ($middlewareTypes as $middlewareType => $middleware) {
                 $name = sprintf('%s-%s', $configType, $middlewareType);
                 yield $name => [$middleware, $config];
             }
@@ -151,6 +152,7 @@ public function callableMiddlewares()
      */
     public function testFactorySetsUpRoutesFromConfig($middleware, $configType)
     {
+        $pingMiddleware = $this->prophesize(MiddlewareInterface::class)->reveal();
         $config = [
             'routes' => [
                 [
@@ -160,7 +162,7 @@ public function testFactorySetsUpRoutesFromConfig($middleware, $configType)
                 ],
                 [
                     'path' => '/ping',
-                    'middleware' => 'Ping',
+                    'middleware' => $pingMiddleware,
                     'allowed_methods' => ['GET'],
                 ],
             ],
@@ -238,7 +240,7 @@ public function testCanSpecifyRouteViaConfigurationWithNoMethods($configType)
             'routes' => [
                 [
                     'path' => '/',
-                    'middleware' => 'HelloWorld',
+                    'middleware' => $this->prophesize(MiddlewareInterface::class)->reveal(),
                 ],
             ],
         ];
@@ -275,7 +277,7 @@ public function testCanSpecifyRouteOptionsViaConfiguration($configType)
             'routes' => [
                 [
                     'path' => '/',
-                    'middleware' => 'HelloWorld',
+                    'middleware' => $this->prophesize(MiddlewareInterface::class)->reveal(),
                     'name' => 'home',
                     'allowed_methods' => ['GET'],
                     'options' => $expected,
@@ -333,7 +335,7 @@ public function testExceptionIsRaisedInCaseOfInvalidRouteOptionsConfiguration($c
             'routes' => [
                 [
                     'path' => '/',
-                    'middleware' => 'HelloWorld',
+                    'middleware' => $this->prophesize(MiddlewareInterface::class)->reveal(),
                     'options' => 'invalid',
                 ],
             ],

test/Middleware/DispatchMiddlewareTest.php

@@ -10,11 +10,13 @@
 use Interop\Http\ServerMiddleware\DelegateInterface;
 use Interop\Http\ServerMiddleware\MiddlewareInterface as ServerMiddlewareInterface;
 use PHPUnit\Framework\TestCase;
+use Prophecy\Argument;
 use Prophecy\Prophecy\ObjectProphecy;
 use Psr\Container\ContainerInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Zend\Expressive\Middleware\DispatchMiddleware;
+use Zend\Expressive\Middleware\LazyLoadingMiddleware;
 use Zend\Expressive\Router\Route;
 use Zend\Expressive\Router\RouteResult;
 use Zend\Expressive\Router\RouterInterface;
@@ -88,11 +90,12 @@ public function testCanDispatchCallableDoublePassMiddleware()
         $this->delegate->process()->shouldNotBeCalled();
 
         $expected = $this->prophesize(ResponseInterface::class)->reveal();
-        $routedMiddleware = function ($request, $response, $next) use ($expected) {
-            return $expected;
-        };
+        $routedMiddleware = $this->prophesize(ServerMiddlewareInterface::class);
+        $routedMiddleware
+            ->process(Argument::that([$this->request, 'reveal']), Argument::that([$this->delegate, 'reveal']))
+            ->willReturn($expected);
 
-        $routeResult = RouteResult::fromRoute(new Route('/', $routedMiddleware));
+        $routeResult = RouteResult::fromRoute(new Route('/', $routedMiddleware->reveal()));
 
         $this->request->getAttribute(RouteResult::class, false)->willReturn($routeResult);
 
@@ -104,19 +107,27 @@ public function testCanDispatchCallableDoublePassMiddleware()
     /**
      * @group 453
      */
-    public function testCanDispatchMiddlewareServices()
+    public function testCanDispatchLazyMiddleware()
     {
         $this->delegate->process()->shouldNotBeCalled();
 
         $expected = $this->prophesize(ResponseInterface::class)->reveal();
-        $routedMiddleware = function ($request, $response, $next) use ($expected) {
-            return $expected;
-        };
+        $routedMiddleware = $this->prophesize(ServerMiddlewareInterface::class);
+        $routedMiddleware
+            ->process(Argument::that([$this->request, 'reveal']), Argument::that([$this->delegate, 'reveal']))
+            ->willReturn($expected);
 
         $this->container->has('RoutedMiddleware')->willReturn(true);
-        $this->container->get('RoutedMiddleware')->willReturn($routedMiddleware);
+        $this->container->get('RoutedMiddleware')->willReturn($routedMiddleware->reveal());
+
+        // Since 2.0, we never have service names in routes, only lazy-loading middleware
+        $lazyMiddleware = new LazyLoadingMiddleware(
+            $this->container->reveal(),
+            $this->responsePrototype->reveal(),
+            'RoutedMiddleware'
+        );
 
-        $routeResult = RouteResult::fromRoute(new Route('/', 'RoutedMiddleware'));
+        $routeResult = RouteResult::fromRoute(new Route('/', $lazyMiddleware));
 
         $this->request->getAttribute(RouteResult::class, false)->willReturn($routeResult);